Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

Thanks Mandy for review! Yumin On 5/6/20 6:50 PM, Mandy Chung wrote: This looks okay to me. Mandy On 5/6/20 6:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ Tests

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

Thanks for review, yes, enough for a push! Yumin On 5/6/20 7:15 PM, David Holmes wrote: On 7/05/2020 12:04 pm, Daniel D. Daugherty wrote: On 5/6/20 9:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev:

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

Thanks for review! Yumin On 5/6/20 6:26 PM, Kim Barrett wrote: On May 6, 2020, at 9:01 PM, Yumin Qi wrote: Hi, Please review the fix for bug: https://bugs.openjdk.java.net/browse/JDK-8244495 webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ Tests

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

On 7/05/2020 12:04 pm, Daniel D. Daugherty wrote: On 5/6/20 9:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ src/java.base/share/native/libjimage/imageDecompressor.cpp  

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

On 5/6/20 9:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ src/java.base/share/native/libjimage/imageDecompressor.cpp     No comments. Thumbs up. I think this qualifies

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

Hi Yumin, On 7/05/2020 11:01 am, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java failed after 8237750

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

This looks okay to me. Mandy On 5/6/20 6:01 PM, Yumin Qi wrote: Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java failed

Re: RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

> On May 6, 2020, at 9:01 PM, Yumin Qi wrote: > > Hi, > Please review the fix for > bug: https://bugs.openjdk.java.net/browse/JDK-8244495 > webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ > > Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java failed > after

RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

Hi,   Please review the fix for   bug: https://bugs.openjdk.java.net/browse/JDK-8244495   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/ Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java failed after 8237750 pushed. The fix of 8237750 changed default behavior of