Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2013-01-03 Thread Joe Wang
On 1/3/2013 3:33 AM, Daniel Fuchs wrote: On 12/27/12 12:06 AM, Joe Wang wrote: Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe Hi Joe, In FactoryFind

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2013-01-03 Thread Daniel Fuchs
On 12/27/12 12:06 AM, Joe Wang wrote: Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe Hi Joe, In FactoryFinder.java - line 213, SchemaFactoryFinder.java

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Chris Hegarty
On 27 Dec 2012, at 22:26, Remi Forax wrote: > On 12/27/2012 10:41 PM, Chris Hegarty wrote: >> Method method = clazz.getMethod(DOM_LEVEL3_METHOD); is equivalent to Method method = clazz.getMethod(DOM_LEVEL3_METHOD, new Class[0]); so you allocate an empty array each time you c

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Remi Forax
On 12/27/2012 10:41 PM, Chris Hegarty wrote: Method method = clazz.getMethod(DOM_LEVEL3_METHOD); is equivalent to Method method = clazz.getMethod(DOM_LEVEL3_METHOD, new Class[0]); so you allocate an empty array each time you call getMethod. A better patch is to cast null to Class[] (or Object[

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Chris Hegarty
Method method = clazz.getMethod(DOM_LEVEL3_METHOD); is equivalent to Method method = clazz.getMethod(DOM_LEVEL3_METHOD, new Class[0]); so you allocate an empty array each time you call getMethod. A better patch is to cast null to Class[] (or Object[] for invoke) Method method = clazz.getMethod(

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Joe Wang
Thanks all! I've updated the webrev with Remi's suggestion. -Joe On 12/27/2012 5:25 AM, Remi Forax wrote: On 12/27/2012 12:06 AM, Joe Wang wrote: Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.ne

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Remi Forax
On 12/27/2012 12:06 AM, Joe Wang wrote: Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe Hi Joe, Method method = clazz.getMethod(DOM_LEVEL3_METHOD); is

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-27 Thread Chris Hegarty
On 27 Dec 2012, at 00:31, Weijun Wang wrote: > The code changes look fine. +1. Nice to see warnings being cleaned up. -Chris > > Thanks > Max > > On 12/27/2012 07:06 AM, Joe Wang wrote: >> Hi, >> >> This is a patch to clean up compiling warnings in jaxp. >> >> Bug: http://bugs.sun.com/vie

Re: RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-26 Thread Weijun Wang
The code changes look fine. Thanks Max On 12/27/2012 07:06 AM, Joe Wang wrote: Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe

RFR: (jaxp) 8005473 : Warnings compiling jaxp

2012-12-26 Thread Joe Wang
Hi, This is a patch to clean up compiling warnings in jaxp. Bug: http://bugs.sun.com/view_bug.do?bug_id=8005473 Webrev: http://cr.openjdk.java.net/~joehw/jdk8/8005473/webrev/ Thanks, Joe