Re: RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-18 Thread Bob Vandette
I will be committing each change individually but thought I’d save some time testing/reviewing. Thanks, Bob. > On Mar 18, 2019, at 10:12 AM, Severin Gehwolf wrote: > > Hi Bob, > > Changes look OK to me. > > I'd prefer if those issues would get addressed separately, though. 3 > webrevs for 3

Re: RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-18 Thread Severin Gehwolf
Hi Bob, Changes look OK to me. I'd prefer if those issues would get addressed separately, though. 3 webrevs for 3 bugs, over lumping 3 bugs into 1 webrev. This makes it A) easier to review B) easier to backport to older releases if/when the time comes. Some of those issues are rather unrelated af

Re: RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-14 Thread David Holmes
Hi Bob, Sorry I took a look but can't really review it in detail as I don't know any of the cgroup details. Not sure who may ... perhaps Misha (cc'd). On 15/03/2019 12:15 am, Bob Vandette wrote: Ping ... Please review these three fixes for Linux Docker/cgroup container support. WEBREV: ht

RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-14 Thread Bob Vandette
Ping ... Please review these three fixes for Linux Docker/cgroup container support. WEBREV: http://cr.openjdk.java.net/~bobv/8217766/webrev.0 ISSUE1: https://bugs.openjdk.java.net/browse/JDK-8219562 - Line of code in osContainer_linux.cpp#L102 appears unreachable This change corrects a rare

Re: RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-11 Thread Bob Vandette
Sorry, missed a link: http://cr.openjdk.java.net/~bobv/8217766/webrev.0/ Bob. > On Mar 11, 2019, at 11:13 AM, Bob Vandette wrote: > > Please review these three fixes for Linux Docker/cgroup container support. > > https://bugs.openjdk.java.

RFR: Container Fixes (8219652, 8217766, 8212528)

2019-03-11 Thread Bob Vandette
Please review these three fixes for Linux Docker/cgroup container support. https://bugs.openjdk.java.net/browse/JDK-8219562 - Line of code in osContainer_linux.cpp#L102 appears unreachable This change corrects a rarely used hotspot code path to be compatible with the Java based Metrics. https: