Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-18 Thread Brian Burkhalter
On Thu, 18 Feb 2021 16:59:54 GMT, Alan Bateman wrote: >> Like so? >> --- a/src/java.base/share/classes/java/io/File.java >> +++ b/src/java.base/share/classes/java/io/File.java >> @@ -1376,7 +1376,9 @@ public class File >> * file from one filesystem to another, it might not be atomic, and

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-18 Thread Alan Bateman
On Thu, 18 Feb 2021 16:43:09 GMT, Brian Burkhalter wrote: >> It might be clearer if the end of the sentence were changed to something >> like "... this File object is not changed to name destination file or >> directory". > > Like so? > --- a/src/java.base/share/classes/java/io/File.java > +++

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-18 Thread Brian Burkhalter
On Thu, 18 Feb 2021 09:24:06 GMT, Alan Bateman wrote: >> No, I intended `filesystem` but in the sense of "object in the filesystem" >> but it does seem awkward. > > It might be clearer if the end of the sentence were changed to something like > "... this File object is not changed to name

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-18 Thread Alan Bateman
On Wed, 17 Feb 2021 22:28:11 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/io/File.java line 1381: >> >>> 1379: * that the rename operation was successful. As instances of >>> {@code File} >>> 1380: * are immutable, the abstract pathname represented by this >>>

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Roger Riggs
On Wed, 17 Feb 2021 22:12:06 GMT, Brian Burkhalter wrote: >> Please review this minor specification update to highlight that >> `File.renameTo(File)` does not modify the `File` instance on which the >> method is invoked. > > Brian Burkhalter has updated the pull request incrementally with one

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Brian Burkhalter
On Wed, 17 Feb 2021 22:24:53 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6245663: Mention 'dest' parameter in the added doc > > src/java.base/share/classes/java/io/File.java line 1381: >

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Naoto Sato
On Wed, 17 Feb 2021 22:12:06 GMT, Brian Burkhalter wrote: >> Please review this minor specification update to highlight that >> `File.renameTo(File)` does not modify the `File` instance on which the >> method is invoked. > > Brian Burkhalter has updated the pull request incrementally with one

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Brian Burkhalter
On Wed, 17 Feb 2021 22:04:38 GMT, Roger Riggs wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6245663: Mention 'dest' parameter in the added doc > > src/java.base/share/classes/java/io/File.java line 1383: >

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Brian Burkhalter
> Please review this minor specification update to highlight that > `File.renameTo(File)` does not modify the `File` instance on which the method > is invoked. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 6245663: Mention

Re: RFR: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance [v2]

2021-02-17 Thread Roger Riggs
On Wed, 17 Feb 2021 22:08:47 GMT, Brian Burkhalter wrote: >> Please review this minor specification update to highlight that >> `File.renameTo(File)` does not modify the `File` instance on which the >> method is invoked. > > Brian Burkhalter has updated the pull request incrementally with one