Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-13 Thread Mandy Chung
Great, thanks! I'll push it for you. Mandy On 3/13/2013 8:28 AM, Jim Gish wrote: Mandy, The CCC request has been approved. Please push the changeset at http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch.patch/

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-13 Thread Jim Gish
Mandy, The CCC request has been approved. Please push the changeset at http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch.patch/ Thanks, Jim On 03/08/2013 05:51 PM, Mandy Ch

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-08 Thread Mandy Chung
On 3/8/2013 2:39 PM, Jim Gish wrote: I've update the webrev with the suggested changes: http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ Thumbs up. Thanks for adding the comment in

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-08 Thread Jim Gish
I've update the webrev with the suggested changes: http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ Thanks, Jim On 03/08/2013 03:41 PM, Mandy Chung wrote: On 3/5/2013 11:12 AM, J

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-08 Thread Mandy Chung
On 3/5/2013 11:12 AM, Jim Gish wrote: For the LoggerResourceBundleRace test then does it have to run in its own VM? Because we no longer search up the stack for the bundles, this test fails unless run in its own vm. However, to avoid this, I'll try to change the test to set the context classlo

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-07 Thread Jim Gish
On 03/06/2013 03:42 PM, Mandy Chung wrote: LoggerResourceBundleRace.java: I think what you really want is to add a new test that sets a context class loader to a class loader that finds the resource bundle for a logger that a system class loader can't find. I suggest to leave this test a

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-06 Thread Mandy Chung
On 3/6/2013 11:42 AM, Jim Gish wrote: http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ L122-125: you may want to replace with {@code } I think we'll save that for a later day - and then update all the occurrences of to {@code} Fine with me. L129-130

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-06 Thread Jim Gish
On 03/06/2013 12:58 PM, Mandy Chung wrote: On 3/5/2013 9:16 AM, Jim Gish wrote: On 03/01/2013 05:48 PM, Mandy Chung wrote: On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-06 Thread Mandy Chung
On 3/5/2013 9:16 AM, Jim Gish wrote: On 03/01/2013 05:48 PM, Mandy Chung wrote: On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() It's good to s

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-05 Thread Jim Gish
The webrev has been updated as requested: http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ A CCC request has been filed. Thanks, Jim On 03/05/2013 02:12 PM, Jim Gish wrote: On 03/03/2013 09:15 AM, Alan Bateman wrote: On 01/03/2013 21:25, Jim Gish wrote: Pleas

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-05 Thread Jim Gish
On 03/03/2013 09:15 AM, Alan Bateman wrote: On 01/03/2013 21:25, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-05 Thread Jim Gish
On 03/01/2013 05:48 PM, Mandy Chung wrote: On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() It's good to see this stack walk search of resource bu

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-03 Thread Alan Bateman
On 01/03/2013 21:25, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() Note that because

Re: RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-01 Thread Mandy Chung
On 3/1/2013 1:25 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() It's good to see this stack walk search of resource bundle going away. In Logger.java, the existin

RFR: 8002070 Remove the stack search for a resource bundle for Logger to use

2013-03-01 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug8002070-RemoveResourceBundleStackSearch/ This removes the stack search from Logger.findResourceBundle() Note that because this is a change in the spec/functional