Re: RFR: 8003380 - Compiler warnings in logging test code

and pushed... http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b829a5a46ee -Chris. On 11/28/2012 06:51 PM, Jim Gish wrote: Since we don't yet have a resolution on this, I modified the test code in question to remove the @SuppressWarnings("unused") and actually removed the unused references (and re

Re: RFR: 8003380 - Compiler warnings in logging test code

I'm a bit happier that @SuppressWarnings("unused") has been removed. Note, I only got pulled into this because of the @SuppressWarnings namespace question; I didn't look at the rest of the webrev. s'marks On 11/28/12 10:51 AM, Jim Gish wrote: Since we don't yet have a resolution on this, I m

Re: RFR: 8003380 - Compiler warnings in logging test code

Since we don't yet have a resolution on this, I modified the test code in question to remove the @SuppressWarnings("unused") and actually removed the unused references (and retested, of course). Please review http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/

Re: RFR: 8003380 - Compiler warnings in logging test code

Here's the list of @suppresswarnings values that are recognized by Eclipse Juno: Excluding warnings using @SuppressWarnings Since Java 5.0, you can disable compilation warnings relative to a subset of a compilation unit using the|java.lang.SuppressWarning|annotation. @SuppressWarning("u

Re: RFR: 8003380 - Compiler warnings in logging test code

Some of these are actually supported by NetBeans, such as: LeakingThisInConstructor Regards, Michael On Sat, Nov 17, 2012 at 12:39 AM, Stuart Marks wrote: > On 11/15/12 3:06 AM, Alan Bateman wrote: >> >> On 14/11/2012 22:44, Chris Hegarty wrote: >>> >>> - @SuppressWarnings("unused") Eclipse??

Re: RFR: 8003380 - Compiler warnings in logging test code

On 11/16/12 6:39 PM, Stuart Marks wrote: The background is that the words that can be supplied to @SuppressWarnings reside in an uncontrolled namespace. The JLS [1] defines only "unchecked" and any others are compiler-specific. The set of words accepted here by javac is the same as the words defi

Re: RFR: 8003380 - Compiler warnings in logging test code

On 11/15/12 3:06 AM, Alan Bateman wrote: On 14/11/2012 22:44, Chris Hegarty wrote: - @SuppressWarnings("unused") Eclipse??? Do we have precedent for adding these suppressions?? I don't see it in the -Xlint options that javac supports so it might be specific to ECJ. I recall this topic cam

Re: RFR: 8003380 - Compiler warnings in logging test code

Well -- yes and no. The problem is the way Loggers are handled -- as weak refs. They can get easily gc'd. Now in this code it doesn't really make much difference, but I'm trying to be consistent. That said, the right thing, now that I look at it again, would be to make the declarations of l

Re: RFR: 8003380 - Compiler warnings in logging test code

Jim, I'm not convinced that the use of "unused" is strictly necessary, but I'm not an Eclipse user. It looks like there is an easy way around this. For example, in new/test/java/util/logging/LoggingDeadlock3.java, rather than add @SuppressWarnings("unused"), will the follow keep the compiler

Re: RFR: 8003380 - Compiler warnings in logging test code

On 14/11/2012 22:44, Chris Hegarty wrote: - @SuppressWarnings("unused") Eclipse??? Do we have precedent for adding these suppressions?? I don't see it in the -Xlint options that javac supports so it might be specific to ECJ. I recall this topic came up during one of the warnings clean-up

Re: RFR: 8003380 - Compiler warnings in logging test code

I've updated the webrev with your suggestion. Here it is: http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/ Could someone please push it? Thanks, Jim On 11/14/2012 05:48 PM, Jim Gish wrote: On 11/1

Re: RFR: 8003380 - Compiler warnings in logging test code

On 11/14/2012 05:44 PM, Chris Hegarty wrote: Interesting... fixing warnings in tests. A few comments. Right -- one might consider it overkill sine the warnings don't show up in normal testing, but they do show up in Eclipse. Just plain annoying. - LoggingMXBeanTest2.java ListIterator -> Li

Re: RFR: 8003380 - Compiler warnings in logging test code

Interesting... fixing warnings in tests. A few comments. - LoggingMXBeanTest2.java ListIterator -> ListIterator and remove redundant cast ? - @SuppressWarnings("unused") Eclipse??? Do we have precedent for adding these suppressions?? - ClassLoaderLeakTest Why the change to use toURI().to

Re: RFR: 8003380 - Compiler warnings in logging test code

looks Ok. On Nov 14, 2012, at 4:15 PM, Jim Gish wrote: > Please review > http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/ > > > These are simple changes to eliminate compiler warnings from > java.util.

RFR: 8003380 - Compiler warnings in logging test code

Please review http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/ These are simple changes to eliminate compiler warnings from java.util.logging test code. Thanks, Jim -- Jim Gish | Consulting Member