Re: RFR: 8004651 - TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

Yes, please. Thanks, Jim On 12/11/2012 07:02 PM, Stuart Marks wrote: Looks good! Do you need someone to push this for you? s'marks On 12/11/12 3:04 PM, Jim Gish wrote: A bit more cleanup as suggested: http://cr.openjdk.java.net/~jgish/Bug8004651-CheckLockLocationTest-Windows-delete-file

Re: RFR: 8004651 - TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

Looks good! Do you need someone to push this for you? s'marks On 12/11/12 3:04 PM, Jim Gish wrote: A bit more cleanup as suggested: http://cr.openjdk.java.net/~jgish/Bug8004651-CheckLockLocationTest-Windows-delete-file-fix/

Re: RFR: 8004651 - TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

A bit more cleanup as suggested: http://cr.openjdk.java.net/~jgish/Bug8004651-CheckLockLocationTest-Windows-delete-file-fix/ Thanks, Jim On 12/10/2012 07:47 PM, Stuart Marks wrote: Hi Jim, Ca

Re: RFR: 8004651 - TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

Hi Jim, Catching IOException from delete() is a bit odd. The only thing in the delete() method that throws an IOE is the explicit throw of FileNotFoundException... so in that case we'd throw FNFE and then catch the IOE at the caller and print a warning. Would it be better to just print a warni

RFR: 8004651 - TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win)

Please review http://cr.openjdk.java.net/~jgish/Bug8004651-CheckLockLocationTest-Windows-delete-file-fix/ Summary -- failure to delete a test log should be a warning instead of a failure. Also, whi