Hi Sherman,
The code changes look good to me, I was thinking about the test and
here are some observations:
test/java/util/zip/TestExtraTime.java
a. you have TZ of Asia/Shanghai, I am wondering if it would help to add
a TZ which
has DST for any DST computation issues that we might
Kumar, Alan,
Here is the latest webrev of the changes based on the latest CCC.
http://cr.openjdk.java.net/~sherman/8015666/webrev
-Sherman
On 07/02/2013 11:29 AM, Xueming Shen wrote:
On 06/28/2013 07:47 AM, Kumar Srinivasan wrote:
Some nits while reading the changes:
1. ZipEntry.java
a.
On 06/28/2013 07:47 AM, Kumar Srinivasan wrote:
Some nits while reading the changes:
1. ZipEntry.java
a. typo:
+ * Sets the laste access time of the entry.
b. extra space
+case EXTID_ZIP64 :
2. ZipOutputStream.java
I think it would be nice to have the flags 0x1,
Some nits while reading the changes:
1. ZipEntry.java
a. typo:
+ * Sets the laste access time of the entry.
b. extra space
+case EXTID_ZIP64 :
2. ZipOutputStream.java
I think it would be nice to have the flags 0x1, 0x2 and 0x4 defined
as constants, this will also
Hi Sherman,
I started looking at this, my initial comment, the Unpacker.unpack
does not close its output and we allow multiple pack files to be
concatenated,
I am assuming out.finish() will allow further jar files to be appended ?
or would this cause a problem ?
Kumar
Hi,
The zip time
On 06/27/2013 10:04 AM, Kumar Srinivasan wrote:
Hi Sherman,
I started looking at this, my initial comment, the Unpacker.unpack
does not close its output and we allow multiple pack files to be concatenated,
I am assuming out.finish() will allow further jar files to be appended ?
or would this
On 20/06/2013 19:48, Xueming Shen wrote:
:
I'm proposing the following approach to add the functionality of
supporting
the utc-date/time-with-1-second granularity and keep the old behavior
of the get/setTime() of the ZipEntry.
(1) keep the time/setTime()/getTime() for the MS-DOS standard
On 6/21/13 6:33 AM, Alan Bateman wrote:
On 20/06/2013 19:48, Xueming Shen wrote:
:
I'm proposing the following approach to add the functionality of
supporting
the utc-date/time-with-1-second granularity and keep the old behavior
of the get/setTime() of the ZipEntry.
(1) keep the
