Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-08-21 Thread Alan Bateman
On 20/08/2013 20:48, Henry Jen wrote: : We are using stream test framework on this to verify all style of stream works, with that we will need to have library on bootclasspath, and that current prevent us from put it in test/java/util/regex because of jtreg limitation. If no object, I'll push th

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-08-21 Thread Paul Sandoz
On Aug 20, 2013, at 11:32 PM, Henry Jen wrote: > On 08/20/2013 12:58 PM, Jonathan Gibbons wrote: >> Henry, >> >> I think you should sort out the issues you are having with jtreg. >> It is not yet clear to me that this is a jtreg issue as much as a test >> or library issue. >> > > Thanks Jon

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-08-20 Thread Henry Jen
On 08/20/2013 12:58 PM, Jonathan Gibbons wrote: > Henry, > > I think you should sort out the issues you are having with jtreg. > It is not yet clear to me that this is a jtreg issue as much as a test > or library issue. > Thanks Jon for the help on jtreg issue, the test can be easily fixed by a

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-08-20 Thread Henry Jen
On 07/24/2013 09:14 AM, Alan Bateman wrote: > On 16/07/2013 12:05, Henry Jen wrote: >> Hi, >> >> Please review the webrev at, >> >> http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ >> >> The test is mostly contributed by Ben Evans. >> >> Cheers, >> Henry >> > It looks okay to me, just a co

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-07-24 Thread Paul Sandoz
On Jul 24, 2013, at 5:14 PM, Alan Bateman wrote: > On 16/07/2013 12:05, Henry Jen wrote: >> Hi, >> >> Please review the webrev at, >> >> http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ >> >> The test is mostly contributed by Ben Evans. >> >> Cheers, >> Henry >> > It looks okay to

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-07-24 Thread Alan Bateman
On 16/07/2013 12:05, Henry Jen wrote: Hi, Please review the webrev at, http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ The test is mostly contributed by Ben Evans. Cheers, Henry It looks okay to me, just a concern that the tests for the regex API are normally in test/java/util/reg

Re: RFR: 8016846: Pattern.splitAsStream tests required

2013-07-23 Thread Paul Sandoz
On Jul 16, 2013, at 8:05 PM, Henry Jen wrote: > Hi, > > Please review the webrev at, > > http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ > > The test is mostly contributed by Ben Evans. > Looks OK to me. Paul.

RFR: 8016846: Pattern.splitAsStream tests required

2013-07-16 Thread Henry Jen
Hi, Please review the webrev at, http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/ The test is mostly contributed by Ben Evans. Cheers, Henry