Alan,
> An alternative might be to just throw the IOException with
> InterruptedException as the cause.
Perfect. Updated in the new webrev.
Dan,
You are completely correct. I was only catering for the case where
"java.nio.file.FileSystemException: : The process cannot
access the file beca
On 11/07/2013 11:04 AM, Alan Bateman wrote:
On 07/11/2013 14:59, Chris Hegarty wrote:
Given both Michael and Alan's comments. I've update the webrev:
http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/
1) more descriptive method names
2) deleteXXX methods return if interrupted, leaving t
On 07/11/2013 14:59, Chris Hegarty wrote:
Given both Michael and Alan's comments. I've update the webrev:
http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/
1) more descriptive method names
2) deleteXXX methods return if interrupted, leaving the
interrupt status set
3) Use Files.copy w
Given both Michael and Alan's comments. I've update the webrev:
http://cr.openjdk.java.net/~chegar/fileUtils.01/webrev/
1) more descriptive method names
2) deleteXXX methods return if interrupted, leaving the
interrupt status set
3) Use Files.copy with REPLACE_EXISTING
4) Use SimpleFileVisit
On 07/11/2013 11:34, Chris Hegarty wrote:
:
I've also received another comment offline about the method names.
They should be more descriptive, and highlight the difference between
these methods and regular delete. So maybe move to public
deleteWithRetry?
That might be a bit better as otherwi
On 07/11/13 11:34, Chris Hegarty wrote:
On 11/07/2013 11:19 AM, Michael McMahon wrote:
Chris,
Would it be useful to add some instrumentation/logging (to System.err)
if it's taking
more than one iteration to delete a file? We could end up with degraded
test performance if there is a general prob
On 11/07/2013 11:19 AM, Michael McMahon wrote:
Chris,
Would it be useful to add some instrumentation/logging (to System.err)
if it's taking
more than one iteration to delete a file? We could end up with degraded
test performance if there is a general problem deleting files, and
otherwise would h
Chris,
Would it be useful to add some instrumentation/logging (to System.err)
if it's taking
more than one iteration to delete a file? We could end up with degraded
test performance if there is a general problem deleting files, and
otherwise would have
no way of understanding what the problem
Virus checkers and, on more modern Windows OSes, Windows Experience
Service, and other external processes, have been causing trouble when it
comes to tests deleting files.
On a number of occasions in the past retry logic has been added to tests
that need to delete files. Also, the jtreg harnes
