Re: RFR: 8024525 - Make Logger log methods call isLoggable()

2013-09-12 Thread Alan Bateman
On 11/09/2013 18:59, Daniel Fuchs wrote: Hi, Please find below a changeset for a small logging RFE: 8024525 - Make Logger log methods call isLoggable() http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/ This change makes the various Logger logging method call isLoggable() instead

Re: RFR: 8024525 - Make Logger log methods call isLoggable()

2013-09-12 Thread Daniel Fuchs
Hi, New changeset incorporating Alan's feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.01/ How/why the test works should now appear more clearly :-) -- daniel On 9/12/13 10:40 AM, Alan Bateman wrote: On 11/09/2013 18:59, Daniel Fuchs wrote: Hi, Please find below a

Re: RFR: 8024525 - Make Logger log methods call isLoggable()

2013-09-12 Thread Alan Bateman
On 12/09/2013 14:36, Daniel Fuchs wrote: Hi, New changeset incorporating Alan's feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.01/ How/why the test works should now appear more clearly :-) -- daniel Thanks for that. I guess I would have used javadoc comments for some of

RFR: 8024525 - Make Logger log methods call isLoggable()

2013-09-11 Thread Daniel Fuchs
Hi, Please find below a changeset for a small logging RFE: 8024525 - Make Logger log methods call isLoggable() http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/ This change makes the various Logger logging method call isLoggable() instead of simply inlining the checks. This should

Re: RFR: 8024525 - Make Logger log methods call isLoggable()

2013-09-11 Thread Mandy Chung
On 9/11/2013 10:59 AM, Daniel Fuchs wrote: Hi, Please find below a changeset for a small logging RFE: 8024525 - Make Logger log methods call isLoggable() http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/ Looks good. ... The test is a bit obscure but it calls all the methods