Re: RFR: 8058230: Improve java.sql toString formatting

2014-09-12 Thread Mandy Chung
On 9/12/14 12:21 PM, Phil Race wrote: Hi, http://hg.openjdk.java.net/jdk9/dev/jdk/rev/267950e85a3b The above changeset for this fix apparently broke the images build. ERROR: Failed module access verification CheckModules.gmk:38: recipe for target 'checkdeps' failed make[3]: Leaving directory '

Re: RFR: 8058230: Improve java.sql toString formatting

2014-09-12 Thread Phil Race
Hi, http://hg.openjdk.java.net/jdk9/dev/jdk/rev/267950e85a3b The above changeset for this fix apparently broke the images build. ERROR: Failed module access verification CheckModules.gmk:38: recipe for target 'checkdeps' failed make[3]: Leaving directory '/opt/jprt/T/P1/173827.xxx/s/make' Main.

Re: RFR: 8058230: Improve java.sql toString formatting

2014-09-11 Thread Ulf Zibis
Maybe consider https://bugs.openjdk.java.net/browse/JDK-6914113 Especially note the last comment there. -Ulf Am 11.09.2014 um 16:44 schrieb Claes Redestad: Hi, requesting reviews for this patch which optimizes java.sql.Date/Time/Timestamp::toString by avoiding some unnecessary object allocati

Re: RFR: 8058230: Improve java.sql toString formatting

2014-09-11 Thread Lance Andersen
Hi Claes, I think this is OK, however, would like to see if others feel if formatDecimalInt should be located elsewhere so that we just make this change once. Best, Lance On Sep 11, 2014, at 10:44 AM, Claes Redestad wrote: > Hi, > > requesting reviews for this patch which optimizes > java

RFR: 8058230: Improve java.sql toString formatting

2014-09-11 Thread Claes Redestad
Hi, requesting reviews for this patch which optimizes java.sql.Date/Time/Timestamp::toString by avoiding some unnecessary object allocations. java.sql.Date had similar optimizations applied which this patch improves upon. bug: https://bugs.openjdk.java.net/browse/JDK-8058230 webrev: http://cr