Looks good to me.
Masayoshi
On 11/20/2014 11:20 AM, Naoto Sato wrote:
OK, fine by me.
Naoto
On 11/19/14 4:37 PM, Martin Buchholz wrote:
Thanks Naoto!
Yeah, I noticed that too, but I'm not comfortable enough with this
code to suggest a really good naming scheme.
There are 3 levels of plurali
OK, fine by me.
Naoto
On 11/19/14 4:37 PM, Martin Buchholz wrote:
Thanks Naoto!
Yeah, I noticed that too, but I'm not comfortable enough with this
code to suggest a really good naming scheme.
There are 3 levels of pluralization here - Attribute Attributes
Attributeses [sic]!?
On Wed, Nov 19,
Thanks Naoto!
Yeah, I noticed that too, but I'm not comfortable enough with this
code to suggest a really good naming scheme.
There are 3 levels of pluralization here - Attribute Attributes
Attributeses [sic]!?
On Wed, Nov 19, 2014 at 3:41 PM, Naoto Sato wrote:
> Hi Martin,
>
> The fix looks goo
Hi Martin,
The fix looks good to me. Although it is not inherently related to your
fix, there are two separate declarations of "newRunAttributes" and
"newRunAttributeValues" in ensureRunBreak() method and their usages are
different! It would be desirable to correct it.
Naoto
On 11/19/14, 3:
Hey Naoto and Masayoshi,
I haven't sent you a friendly code review in a while.
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/AttributedString-optimization/
https://bugs.openjdk.java.net/browse/JDK-8065159
(AttributedString could also independently see some testing and code
hygiene love)
