Re: RFR: 8077395: org.omg.CORBA_2_3.portable.InputStream constructor should not specify JDK-specific property

2017-01-20 Thread Seán Coffey
Roger, Lance, Thanks for the reviews. I'll make the suggested edit before pushing. Just waiting on CCC approval now. Regards, Sean. On 19/01/17 18:28, Roger Riggs wrote: Hi Sean, Looks ok but can you turn those texts into a sentence (capitalize it and final ".'). Thanks, Roger On 1/19/

Re: RFR: 8077395: org.omg.CORBA_2_3.portable.InputStream constructor should not specify JDK-specific property

2017-01-19 Thread Lance Andersen
Hi Sean, The changes look OK. I would capitalize ‘throws’ and looks like you are missing a period HTH Lance > On Jan 19, 2017, at 12:59 PM, Seán Coffey wrote: > > Changes made to the CORBA InputStream/OutputStream class back in 2013 > contained javadoc comments which should have been marked

Re: RFR: 8077395: org.omg.CORBA_2_3.portable.InputStream constructor should not specify JDK-specific property

2017-01-19 Thread Roger Riggs
Hi Sean, Looks ok but can you turn those texts into a sentence (capitalize it and final ".'). Thanks, Roger On 1/19/2017 12:59 PM, Seán Coffey wrote: Changes made to the CORBA InputStream/OutputStream class back in 2013 contained javadoc comments which should have been marked as implementa

RFR: 8077395: org.omg.CORBA_2_3.portable.InputStream constructor should not specify JDK-specific property

2017-01-19 Thread Seán Coffey
Changes made to the CORBA InputStream/OutputStream class back in 2013 contained javadoc comments which should have been marked as implementation specific. The minor edits here should correct that. webrev : http://cr.openjdk.java.net/~coffeys/webrev.8077395/webrev/ JBS : https://bugs.openjdk.jav