Re: RFR: 8079841: Buffer underflow with empty zip entry names

2015-05-12 Thread Martin Buchholz
Committed! On Fri, May 8, 2015 at 11:33 AM, Xueming Shen wrote: > looks good! > > > On 5/8/15 10:58 AM, Jeremy Manson wrote: > >> There's a fairly harmless buffer underflow with empty zip names in libzip. >> Martin has offered to sponsor this (right, Martin?). >> >> We detected this with ASan, a

Re: RFR: 8079841: Buffer underflow with empty zip entry names

2015-05-08 Thread Xueming Shen
looks good! On 5/8/15 10:58 AM, Jeremy Manson wrote: There's a fairly harmless buffer underflow with empty zip names in libzip. Martin has offered to sponsor this (right, Martin?). We detected this with ASan, an automatic memory error and leak checking tool built into Clang/LLVM. This is one o