RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-08-31 Thread Henry Jen
Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain, report error and exit. Cheers, Henry diff --git a/src/

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-08-31 Thread Kumar Srinivasan
Looks good, thanks Henry for fixing this. Kumar Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain, rep

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-09-01 Thread David Holmes
On 1/09/2016 5:51 AM, Henry Jen wrote: Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain, report error an

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-09-01 Thread Henry Jen
That’s what I think too, this is just to silent parfait. I don’t know for sure that we always get NULL with exception pending though. Cheers, Henry On September 1, 2016 at 12:34:02 AM, David Holmes (david.hol...@oracle.com) wrote: > On 1/09/2016 5:51 AM, Henry Jen wrote: > > Hi, > > > > Please r

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-09-01 Thread David Holmes
On 2/09/2016 2:03 AM, Henry Jen wrote: That’s what I think too, this is just to silent parfait. We are doing similar things in VM code, but the NULL check suffices. If that is not the case here then I think a Parfait bug needs to be filed. I don’t know for sure that we always get NULL with