Some comments:
General
*) Shouldn't the javadocs be put mentions of null in {@code null} tags?
*) Many methods are documented to throw SQLFeatureNotSupportedException
when sharding isn't supported, but the error message actually says "XYZ not
implemented". Well I think that places an immediate bur
See: http://cr.openjdk.java.net/~lancea/8085984/webrev.01/
On Nov 24, 2015, at 10:31 AM, Paul Benedict wrote:
> Some comments:
>
> General
> *) Shouldn't the javadocs be put mentions of null in {@code null} tags?
Probably, JDBC javadocs are inconsistent WRT null (and vs {@code} so it
needs a
Quick clarification on my last point:
createShardingKeyBuilder() is not guaranteed to be implemented ... even
with sharding supported. This method is documented to be optional; it does
not contain the usual "if sharding is not supported" warning but "if the
driver does not support this method", whi
Hi Joe,
Thank you and Ulf for catching the error message typo as we changed the name of
the method. I will fix that before I push
Best
Lance
On Nov 23, 2015, at 7:09 PM, huizhe wang wrote:
> Hi Lance,
>
> Looks good, except as Ulf pointed out already, in both in Connection.java and
> XACon
Hi Lance,
Looks good, except as Ulf pointed out already, in both in
Connection.java and XAConnection.java, SQLFeatureNotSupportedException
should have been thrown with a message "setShardingKeyIfValid not
implemented" rather than "isValid not implemented" (4 occurrences in total).
Best,
Joe
Hi,
Isn't it "i_f_Valid not implemented" instead "i_s_Valid not implemented" or eventually
"setShardingKeyIfValid not implemented"?
-Ulf
Am 24.11.2015 um 00:01 schrieb Lance Andersen:
Hi all,
Need a reviewer for 8085984, which adds support for Sharding. The CCC has been
approved. The w
Hi all,
Need a reviewer for 8085984, which adds support for Sharding. The CCC has been
approved. The webrev can be found at
http://cr.openjdk.java.net/~lancea/8085984/webrev.00/
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Netw
