> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
On Wed, 23 Sep 2020 20:02:45 GMT, Erik Gahlin wrote:
>> Philippe Marschall has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now
>> contains one commit:
>> 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate
>
> Marked as reviewed
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change
On 23.09.20 07:13, David Holmes wrote:
On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
Marked as reviewed by kvn (Reviewer).
Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
On 22.09.20 10:45, Erik Gahlin wrote:
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
Philippe Marschall has refreshed the contents of this pull request, and
previous commits have been removed. The
incremental views will show differences compared to the previous content of the
On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
>> Marked as reviewed by kvn (Reviewer).
>
> Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
reviews/comments obsolete. There is no
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The pull request contains one
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change
On Fri, 11 Sep 2020 21:53:12 GMT, Vladimir Kozlov wrote:
>> Marked as reviewed by psandoz (Reviewer).
>
> You should consider upstreaming Graal changes (jdk.internal.vm.compiler) into
> https://github.com/oracle/graal
> Otherwise next time we do "Update Graal" in JDK they will be overwritten.
On Thu, 10 Sep 2020 17:59:54 GMT, Paul Sandoz wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR.
>
> Marked as reviewed by psandoz
On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change
On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change
On Mon, Sep 7, 2020 at 7:54 PM Alan Bateman wrote:
>
> On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
> wrote:
>
> > Hello, newbie here
> >
> > I picked JDK-8138732 to work on because it has a "starter" label and I
> > believe I understand what to do.
> >
> > - I tried to update the
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since`
Hi Philippe,
On 8/09/2020 3:08 am, Philippe Marschall wrote:
Hello, newbie here
Welcome aboard!
I picked JDK-8138732 to work on because it has a "starter" label and I believe
I understand what to do.
- I tried to update the copyright year to 2020 in every file.
- I decided to change
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since`
Hello, newbie here
I picked JDK-8138732 to work on because it has a "starter" label and I believe
I understand what to do.
- I tried to update the copyright year to 2020 in every file.
- I decided to change `@since` from 9 to 16 since it is a new annotation name
in a new package.
- I tried to
22 matches
Mail list logo
