Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-05-02 Thread Daniel Fuchs
On 02/05/16 20:06, Mandy Chung wrote: On May 2, 2016, at 10:59 AM, Daniel Fuchs wrote: Hi Mandy, I applied the suggested changes. http://cr.openjdk.java.net/~dfuchs/8139982_webrev/webrev.08/index.html Looks very good and much cleaner. Nits: 166 // The

Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-05-02 Thread Mandy Chung
> On May 2, 2016, at 10:59 AM, Daniel Fuchs wrote: > > Hi Mandy, > > I applied the suggested changes. > > http://cr.openjdk.java.net/~dfuchs/8139982_webrev/webrev.08/index.html > Looks very good and much cleaner. Nits: 166 // The LoggingMXBeanSupport class

Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-05-02 Thread Daniel Fuchs
Hi Mandy, I applied the suggested changes. http://cr.openjdk.java.net/~dfuchs/8139982_webrev/webrev.08/index.html best regards, -- daniel On 02/05/16 19:00, Mandy Chung wrote: hanks a lot for the feedback! > > New webrev here: >

Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-05-02 Thread Mandy Chung
> On May 2, 2016, at 7:13 AM, Daniel Fuchs wrote: > > >> One question about: >> ManagementFactory::getPlatformMXBean(MBeanServerConnection, >> PlatformLoggingMXBean.class) >> - what would happen if this method is called from an image with java.logging >> module

Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-05-02 Thread Daniel Fuchs
Hi Mandy, Answers inline, and new webrev at the end. On 29/04/16 21:55, Mandy Chung wrote: Hi Daniel, On Apr 29, 2016, at 8:08 AM, Daniel Fuchs wrote: Hi, Please find below a patch [2] that eliminates a static dependency of java.lang.management on

Re: RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-04-29 Thread Mandy Chung
Hi Daniel, > On Apr 29, 2016, at 8:08 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch [2] that eliminates a static > dependency of java.lang.management on java.util.logging.LoggingMXBean. > > When JDK-6876135 was fixed, it introduced the

RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

2016-04-29 Thread Daniel Fuchs
Hi, Please find below a patch [2] that eliminates a static dependency of java.lang.management on java.util.logging.LoggingMXBean. When JDK-6876135 was fixed, it introduced the PlatformLoggingMXBean interface, and recommended using PlatformLoggingMXBean over LoggingMXBean. However, it left a