Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-19 Thread David Holmes
Thanks Alexandr! David On 19/07/2016 9:26 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for thi

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/16/2016 2:55 AM, David Holmes wrote: Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we add

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-15 Thread David Holmes
Can I please get someone from AWT to approve this. Thanks, David On 14/07/2016 2:25 PM, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded product no longer n

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-14 Thread David Holmes
Thanks for the review Paul! David On 14/07/2016 11:12 PM, Paul Sandoz wrote: On 14 Jul 2016, at 06:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedde

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-14 Thread David Holmes
Thanks for the review Alan! David On 15/07/2016 6:52 AM, Alan Bateman wrote: On 14/07/2016 05:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded produc

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-14 Thread Alan Bateman
On 14/07/2016 05:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded product no longer need to be there for JDK 9. Many of them have already been removed

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-14 Thread Paul Sandoz
> On 14 Jul 2016, at 06:25, David Holmes wrote: > > The bug report for this is confidential but quite simply all of the little > tweaks and knobs we added to the open build and source files to support the > Java SE Embedded product no longer need to be there for JDK 9. Many of them > have alr

RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

2016-07-13 Thread David Holmes
The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded product no longer need to be there for JDK 9. Many of them have already been removed via other changes but this cleans up the r