Re: RFR: 8153133: Thread.dumpStack() can use StackWalker [v2]

2021-11-08 Thread Jaikiran Pai
On Mon, 8 Nov 2021 15:46:22 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/lang/Thread.java line 1396: >> >>> 1394: // at this point in time. So we fallback to creating a >>> Exception instance >>> 1395: // and printing its stacktrace >>> 1396: new Exceptio

Re: RFR: 8153133: Thread.dumpStack() can use StackWalker [v2]

2021-11-08 Thread Jaikiran Pai
On Mon, 8 Nov 2021 15:53:54 GMT, Jaikiran Pai wrote: >>> printStackTrace interacts with locking of the streams to avoid garbled >>> output when many threads are printing to standard output output/error at >>> the same time. If we change dumpStack to use StackWalker then it will need >>> to do

Re: RFR: 8153133: Thread.dumpStack() can use StackWalker [v2]

2021-11-08 Thread Jaikiran Pai
On Mon, 8 Nov 2021 11:12:25 GMT, Alan Bateman wrote: > printStackTrace interacts with locking of the streams to avoid garbled output > when many threads are printing to standard output output/error at the same > time. If we change dumpStack to use StackWalker then it will need to do the > same

Re: RFR: 8153133: Thread.dumpStack() can use StackWalker [v2]

2021-11-08 Thread Jaikiran Pai
> Can I please get a review of this change which seeks to implement the > enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8153133? > > The commit in this PR uses the `StackWalker` API to dump the stacktrace of > the thread. A few things to note about this change: > > - Previously,