On 2016-06-28 00:11, Iris Clark wrote:
HI, Claes.
Sorry, uploaded the previous diff again by mistake, updated in-place now.
I see the expected changes for unmodifiableList() now. Your changeset is
ready to go from my point of view.
Thanks!
Pushed.
/Claes
PM
To: Mandy Chung
Cc: Iris Clark; core-libs-dev; build-dev
Subject: Re: RFR: 8160000: Runtime.version() cause startup regressions in 9+119
Sorry, uploaded the previous diff again by mistake, updated in-place now.
On 2016-06-28 00:04, Mandy Chung wrote:
>
>> On Jun 27, 2016, at 2:
Sorry, uploaded the previous diff again by mistake, updated in-place now.
On 2016-06-28 00:04, Mandy Chung wrote:
On Jun 27, 2016, at 2:43 PM, Claes Redestad wrote:
To accommodate your change request w.r.t. unmodifiableList above I took the
liberty of cleaning up VersionBuilder.parse() a bi
> On Jun 27, 2016, at 2:43 PM, Claes Redestad wrote:
>
> To accommodate your change request w.r.t. unmodifiableList above I took the
> liberty of cleaning up VersionBuilder.parse() a bit, though. Hope you don't
> mind:
>
> http://cr.openjdk.java.net/~redestad/816/webrev.6/
Moving Collect
On 2016-06-27 22:11, Iris Clark wrote:
Hi, Claes.
[ Sorry for the premature send, my keyboard started interpreting my shortcuts
in unexpected ways. ]
http://cr.openjdk.java.net/~redestad/816/webrev.5/
Nice bugid.
I can hardly believe my luck! :-)
Overall, this change looks good.
Hi, Claes.
[ Sorry for the premature send, my keyboard started interpreting my shortcuts
in unexpected ways. ]
> http://cr.openjdk.java.net/~redestad/816/webrev.5/
Nice bugid.
Overall, this change looks good. I just have a few concerns.
Have you built this forcing alternative build number
ative build numbers? I
-Original Message-
From: Claes Redestad
Sent: Sunday, June 26, 2016 12:56 PM
To: core-libs-dev Libs; build-dev
Subject: RFR: 8160000: Runtime.version() cause startup regressions in 9+119
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early,
caus
Libs; build-dev
Subject: RFR: 816: Runtime.version() cause startup regressions in 9+119
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early,
causing a number of easily reproducible startup regressions.
This patch uses the fact that we already maintain the version string
On 2016-06-27 18:14, Mandy Chung wrote:
On Jun 27, 2016, at 9:10 AM, Claes Redestad wrote:
On 2016-06-27 17:22, Mandy Chung wrote:
On Jun 27, 2016, at 7:16 AM, Claes Redestad wrote:
http://cr.openjdk.java.net/~redestad/816/webrev.4/
Looks good in general.
Thanks Mandy,
I su
> On Jun 27, 2016, at 9:10 AM, Claes Redestad wrote:
>
>
>
> On 2016-06-27 17:22, Mandy Chung wrote:
>>
>>> On Jun 27, 2016, at 7:16 AM, Claes Redestad
>>> wrote:
>>>
>>> http://cr.openjdk.java.net/~redestad/816/webrev.4/
>>
>> Looks good in general.
>
> Thanks Mandy,
>
>> I suggest
On 2016-06-27 17:22, Mandy Chung wrote:
On Jun 27, 2016, at 7:16 AM, Claes Redestad wrote:
http://cr.openjdk.java.net/~redestad/816/webrev.4/
Looks good in general.
Thanks Mandy,
I suggest VersionProps::build to return Optional rather than
Optional and make the methods in Version
> On Jun 27, 2016, at 7:16 AM, Claes Redestad wrote:
>
> http://cr.openjdk.java.net/~redestad/816/webrev.4/
Looks good in general. I suggest VersionProps::build to return
Optional rather than Optional and make the methods in
VersionProps package-private.
Mandy
On 2016-06-27 16:36, Remi Forax wrote:
BTW, i don't know why you're using Integerr.parseInt() when for the build
numbers in Version.parse() but Integer.valueOf() in version().
Oops, but since we're boxing in both cases we end up with the same
bytecode. I'll make the arbitrary choice and use p
- Mail original -
De: "Claes Redestad"
À: "Paul Sandoz"
Cc: core-libs-dev@openjdk.java.net
Envoyé: Lundi 27 Juin 2016 16:16:45
Objet: Re: RFR: 816: Runtime.version() cause startup regressions in
9+119
On 2016-06-27 11:18, Paul Sandoz wrote:
On 27 Jun 201
> BTW, i don't know why you're using Integerr.parseInt() when for the build
> > numbers in Version.parse() but Integer.valueOf() in version().
> >
> > regards,
> > Rémi
> >
> >
> > - Mail original -
> >> De: "
gards,
> Rémi
>
>
> - Mail original -
>> De: "Claes Redestad"
>> À: "Paul Sandoz"
>> Cc: core-libs-dev@openjdk.java.net
>> Envoyé: Lundi 27 Juin 2016 16:16:45
>> Objet: Re: RFR: 816: Runtime.version() cause startup reg
et: Re: RFR: 816: Runtime.version() cause startup regressions in 9+119
>
>
>
> On 2016-06-27 11:18, Paul Sandoz wrote:
> >
> >> On 27 Jun 2016, at 10:39, Claes Redestad
> >> wrote:
> >>
> >> Hi Paul,
> >>
> >> On 2016-
> On 27 Jun 2016, at 16:16, Claes Redestad wrote:
>>
-
957 if (!VersionProps.VERSION_PRE.isEmpty()) {
958 pre = Optional.of(VersionProps.VERSION_PRE);
959 } else {
960 pre = Optional.empty();
961
On 2016-06-27 11:18, Paul Sandoz wrote:
On 27 Jun 2016, at 10:39, Claes Redestad wrote:
Hi Paul,
On 2016-06-27 10:07, Paul Sandoz wrote:
On 26 Jun 2016, at 21:55, Claes Redestad wrote:
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early, causing a
number of easily
On 2016-06-27 11:43, Erik Joelsson wrote:
Build changes look good.
Thanks!
Build changes look good.
/Erik
On 2016-06-26 21:55, Claes Redestad wrote:
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early,
causing a number of easily reproducible startup regressions.
This patch uses the fact that we already maintain the version string
constituents d
> On 27 Jun 2016, at 10:39, Claes Redestad wrote:
>
> Hi Paul,
>
> On 2016-06-27 10:07, Paul Sandoz wrote:
>>
>>> On 26 Jun 2016, at 21:55, Claes Redestad wrote:
>>>
>>> Hi,
>>>
>>> 9+119 changed java.util.regex to initialize java.lang.invoke early, causing
>>> a number of easily reproduci
Hi Paul,
On 2016-06-27 10:07, Paul Sandoz wrote:
On 26 Jun 2016, at 21:55, Claes Redestad wrote:
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early, causing a
number of easily reproducible startup regressions.
This patch uses the fact that we already maintain the versi
> On 26 Jun 2016, at 21:55, Claes Redestad wrote:
>
> Hi,
>
> 9+119 changed java.util.regex to initialize java.lang.invoke early, causing a
> number of easily reproducible startup regressions.
>
> This patch uses the fact that we already maintain the version string
> constituents during buil
Hi,
9+119 changed java.util.regex to initialize java.lang.invoke early,
causing a number of easily reproducible startup regressions.
This patch uses the fact that we already maintain the version string
constituents during build time to simplify creation of the
java.lang.Runtime.version().
25 matches
Mail list logo
