Re: RFR: 8166398: CatalogSupport tests need to be fixed -> Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-22 Thread Joe Wang
Thanks Daniel! I'm glad the issue was caught! I'm also making sure any the debugging method shall throw Exception as well :-) Best, Joe On 9/22/16, 2:09 AM, Daniel Fuchs wrote: Hi Joe, Looks good to me. Thanks for having taken the time to take a second look :-) best regards, -- daniel O

Re: RFR: 8166398: CatalogSupport tests need to be fixed -> Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-22 Thread Daniel Fuchs
Hi Joe, Looks good to me. Thanks for having taken the time to take a second look :-) best regards, -- daniel On 21/09/16 17:47, Joe Wang wrote: Hi Daniel, Here's the fix for the test issues, a couple of errors including missing handler in StAX test, and dtd was mistakingly typed as xsd . Th

RFR: 8166398: CatalogSupport tests need to be fixed -> Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-21 Thread Joe Wang
Hi Daniel, Here's the fix for the test issues, a couple of errors including missing handler in StAX test, and dtd was mistakingly typed as xsd . The root cause is a debugging assertEquals method that printed out debugging message without throwing Exception. I've searched the jaxp/test to make

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-20 Thread Joe Wang
On 9/20/16, 2:20 AM, Daniel Fuchs wrote: Hi Joe, test/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java 603 /** 604 * Returns the text of the first element found by the reader. 605 * @param streamReader the XMLStreamReader 606 * @return the text of the first eleme

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-20 Thread Daniel Fuchs
Hi Joe, test/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java 603 /** 604 * Returns the text of the first element found by the reader. 605 * @param streamReader the XMLStreamReader 606 * @return the text of the first element 607 * @throws XMLStreamException 6

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Joe Wang
Thanks Lance! Best Joe On 9/19/16, 1:13 PM, Lance Andersen wrote: Hi Joe, Seems OK. Best Lance On Sep 19, 2016, at 3:11 PM, Joe Wang > wrote: Hi, Please review an addition of StAX tests to the Catalog Support test set. JBS: https://bugs.openjdk.java.net/brow

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Lance Andersen
Hi Joe, Seems OK. Best Lance > On Sep 19, 2016, at 3:11 PM, Joe Wang wrote: > > Hi, > > Please review an addition of StAX tests to the Catalog Support test set. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8166220 > webrev: http://cr.openjdk.java.net/~joehw/jdk9/8166220/webrev/ > > Than

RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Joe Wang
Hi, Please review an addition of StAX tests to the Catalog Support test set. JBS: https://bugs.openjdk.java.net/browse/JDK-8166220 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8166220/webrev/ Thanks, Joe