Hi,
Please review the webrev[1], the fix is to ensure —class-path and —class-path=
is processed correctly to expand wildcard. Changes are made in jdk repo.
However, test case to verify the bug fix is in langtool repo.
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/jdk9/8172309/0/
[2] h
Hi Henry,
Looks ok to me. Thanks for making this change.
Kumar
Hi,
Please review the webrev[1], the fix is to ensure —class-path and —class-path=
is processed correctly to expand wildcard. Changes are made in jdk repo.
However, test case to verify the bug fix is in langtool repo.
Cheers,
Henry,
You've changed old test cases into new test cases, thereby eliminating
the old cases, which is not so good.
You should be adding new test cases, but changing old ones.
-- Jon
On 01/26/2017 02:31 PM, Kumar Srinivasan wrote:
Hi Henry,
Looks ok to me. Thanks for making this change.
> On Jan 26, 2017, at 4:09 PM, Jonathan Gibbons
> wrote:
>
> Henry,
>
> You've changed old test cases into new test cases, thereby eliminating the
> old cases, which is not so good.
>
> You should be adding new test cases, but changing old ones.
>
I am not sure, I believe all wild-card case
How about following patch instead for langtools repo?
diff -r ef142ac9824e test/tools/javac/Paths/wcMineField.sh
--- a/test/tools/javac/Paths/wcMineField.sh Thu Jan 26 16:53:56 2017 -0800
+++ b/test/tools/javac/Paths/wcMineField.sh Fri Jan 27 13:10:12 2017 -0800
@@ -26,7 +26,7 @@
#
# @te
OK
-- Jon
On 01/27/2017 01:12 PM, Henry Jen wrote:
How about following patch instead for langtools repo?
diff -r ef142ac9824e test/tools/javac/Paths/wcMineField.sh
--- a/test/tools/javac/Paths/wcMineField.sh Thu Jan 26 16:53:56 2017 -0800
+++ b/test/tools/javac/Paths/wcMineField.sh Fri
I would try to avoid having the wildcard code know about the various ways
of specifying classpath. We now have 3 different classpath flags - can
they be canonicalized into one form before wildcard handling?
On Wed, Jan 25, 2017 at 1:23 PM, Henry Jen wrote:
> Hi,
>
> Please review the webrev[1],
Can we have tests in sets of threes, checking -cp, -classpath,
--class-path (and perhaps also CLASSPATH environment)
--- a/test/tools/launcher/ClassPathWildCard.sh
+++ b/test/tools/launcher/ClassPathWildCard.sh
@@ -125,7 +125,7 @@
CheckFail TestA
rm -f TestB${OUTEXT}
- $JAVA${variant} -cl