Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Lance, thanks for this review too! Best, Aleksei On 06/16/2017 07:20 PM, Lance Andersen wrote: Hi Aleks, This looks fine minus the request of Bill to revert. So no need to see the changes you reverted again Best Lance On Jun 16, 2017, at 12:17 PM, Aleks Efimov

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Aleks, This looks fine minus the request of Bill to revert. So no need to see the changes you reverted again Best Lance > On Jun 16, 2017, at 12:17 PM, Aleks Efimov wrote: > > Hi, > > Please, help to review the latest changes that addresses the following >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Thank you, Mandy! Best, Aleksei On 06/16/2017 06:19 PM, Mandy Chung wrote: On Jun 16, 2017, at 9:17 AM, Aleks Efimov wrote: : 4. Update jdk/test/jdk/modules/etc/JdkQualifiedExportTest.java to remove "java.xml/com.sun.xml.internal.stream.writers” from

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On Jun 16, 2017, at 9:17 AM, Aleks Efimov wrote: > > : > 4. Update jdk/test/jdk/modules/etc/JdkQualifiedExportTest.java to remove > "java.xml/com.sun.xml.internal.stream.writers” from KNOWN_EXCEPTION. > >Removed "java.xml/com.sun.xml.internal.stream.writers”

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Bill, Sure - will revert it. On 06/16/2017 06:05 PM, Bill Shannon wrote: Aleks Efimov wrote on 6/16/17 9:17 AM: 3. MimetypesFileTypeMap.java: - Are the Parens around lines 54-57 really needed? I think that the parens are not needed too. Removed them + also removed parens

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Aleks Efimov wrote on 6/16/17 9:17 AM: > 3. MimetypesFileTypeMap.java: > - Are the Parens around lines 54-57 really needed? > > I think that the parens are not needed too. Removed them + also > removed > parens from MailcapCommandMap javadoc. > Bill, please, confirm if you

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, Please, help to review the latest changes that addresses the following comments: 1. JAXBContext for methods such as createValidator() I would suggest adding the @Deprecated annotation @Deprecated added to JAXBContext::createValidator 2. jdk.xml.bind and jdk.xml.ws have been

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Aleks, can you please address Lance’s comments and commit the patch to JDK? —Dmitry > On 13 Jun 2017, at 20:28, Mandy Chung wrote: > > My comment can be addressed separately as a follow-up issue. I’m okay with > that. > > I suggest to get Aleks’ help to get this

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

My comment can be addressed separately as a follow-up issue. I’m okay with that. I suggest to get Aleks’ help to get this change in JDK 9 asap. Mandy > On Jun 13, 2017, at 11:11 AM, Lance Andersen > wrote: > > I think that is fine. You would also want to make

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

I think that is fine. You would also want to make sure that Mandy’s feedback was addressed. Best Lance > On Jun 13, 2017, at 2:08 PM, Dmitry Kornilov > wrote: > > Roman is on vacation this week and coming back next Tuesday, May 20. If we > are in a hurry with

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Roman is on vacation this week and coming back next Tuesday, May 20. If we are in a hurry with this sync (and we are) I can ask Aleks Efimov to make these changes and commit it to JDK. —Dmitry > On 13 Jun 2017, at 01:24, Lance Andersen wrote: > > Hi Roman, > >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Roman, Overall looks OK. A couple of minor comments - JAXBContext for methods such as createValidator() I would suggest adding the @Deprecated annotation - jdk.xml.bind and jdk.xml.ws have been updated via http://hg.openjdk.java.net/jdk9/dev/jaxws/rev/0d797e800441

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On Jun 1, 2017, at 10:29 PM, Roman Grigoriadi > wrote: > > >> On 1 Jun 2017, at 21:25, Mandy Chung > > wrote: >> >> >>> On May 31, 2017, at 5:06 AM, Roman Grigoriadi >>

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On 1 Jun 2017, at 21:25, Mandy Chung wrote: > > >> On May 31, 2017, at 5:06 AM, Roman Grigoriadi >> wrote: >> >> Hi, >> >> New webrev can be found here: >> http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/ >>

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On May 31, 2017, at 5:06 AM, Roman Grigoriadi > wrote: > > Hi, > > New webrev can be found here: > http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/ >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On Jun 1, 2017, at 2:18 PM, Roman Grigoriadi > wrote: > >> >> On 1 Jun 2017, at 20:08, Lance Andersen > > wrote: >> >> Hi Aleks, >> >> Its all good. I don’t suppose there is a webrev of the diffs

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

> On 1 Jun 2017, at 20:08, Lance Andersen wrote: > > Hi Aleks, > > Its all good. I don’t suppose there is a webrev of the diffs from 01 to 02 > (or an easy way to see what changed)? Unfortunately no list of changed files, just a description of changes in my last

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Aleks, Its all good. I don’t suppose there is a webrev of the diffs from 01 to 02 (or an easy way to see what changed)? Best Lance > On Jun 1, 2017, at 2:06 PM, Aleks Efimov wrote: > > I'm sorry Lance! I'm uploading new version of the webrev right now to the >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

I'm sorry Lance! I'm uploading new version of the webrev right now to the same location :-) It should be on-line soon =) Best, Aleksei On 06/01/2017 06:34 PM, Lance Andersen wrote: Hi Roman, The webrev seems to have gotten moved as I was reviewing it and now it is gone :-) On May 31,

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Roman, The webrev seems to have gotten moved as I was reviewing it and now it is gone :-) > On May 31, 2017, at 8:06 AM, Roman Grigoriadi > wrote: > > Hi, > > New webrev can be found here: > http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, New webrev can be found here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/ Previous review comments have been addressed. New changes since last webrev upload: Few “opens xxx to java.xml.bind” in the

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Roman, I made a pass through the webrev and have the following feedback: src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/StaxLazySourceBridge.java and several files - which follow in the webrev, have formatting issues with the newly added @override and existing

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Shouldn't the version information be in the manifest for the jar file containing the classes, accessed via java.lang.Package? Roman Grigoriadi wrote on 05/ 3/17 09:49 AM: > Hi, > > you can find new web rev here: > http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/01/ >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, you can find new web rev here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/01/ Previous review comments are addressed. > The change to version.properties reminds me to ask if there is anything in >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

I got no response to this so I'm assuming everyone is happy now! :-) Bill Shannon wrote on 03/15/2017 03:20 PM: > Looks like I have a chance to tweak the comments for the JAF changes. > Any final comments before I apply these changes to all 4 copies of > this code? > > $ diff -u

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Looks like I have a chance to tweak the comments for the JAF changes. Any final comments before I apply these changes to all 4 copies of this code? $ diff -u MailcapCommandMap.java.orig MailcapCommandMap.java --- MailcapCommandMap.java.orig 2017-03-15 15:10:43.731176917 -0700 +++

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi all, Additional minor comments on top of what others already provided MimetypesFileTypeMap.java - Are the Parens around lines 54-57 really needed? - defaultType and confDir, shouldn’t these be all caps like PROG? - For the doPrivileged method, not sure the minimum

RE: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, Bill. >> 59 * (Where java.home is the value of the "java.home" System >> property >> 60 * and conf is the directory named "conf" if it exists, >> 61 * otherwise the directory named "lib"; the "conf" directory was >> 62 * introduced in JDK 1.9.) In line 62, can we change "JDK

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Alan Bateman wrote on 03/12/17 08:14 AM: > In MailcapCommandMap then the following doesn't seem right for the class > description: > > 59 * (Where java.home is the value of the "java.home" System > property > 60 * and conf is the directory named "conf" if it exists, > 61 * otherwise the

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

On 12/03/2017 14:39, Roman Grigoriadi wrote: Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8176508 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/00/ I skimmed the changes and have a few

RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8176508 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/00/ Summary of changes: jaxws/src/java.activation/share/classes/javax/activation/* These are