Re: RFR: 8180385: fix HTML issues in java.xml module

2017-05-16 Thread Lance Andersen
Hi Jon, Thank you for the explanation. Makes sense. No worries :-) Best Lance > On May 16, 2017, at 7:02 PM, Jonathan Gibbons > wrote: > > Lance, > > The name seemed unnecessary given the context of the method associated with > the doc comment (i.e getNamespaceURI) and the preceding senten

Re: RFR: 8180385: fix HTML issues in java.xml module

2017-05-16 Thread Jonathan Gibbons
Lance, The name seemed unnecessary given the context of the method associated with the doc comment (i.e getNamespaceURI) and the preceding sentence: >> the following table describes the returned Namespace URI value for all possible prefix values: If that was editorial overreach, I apologise

Re: RFR: 8180385: fix HTML issues in java.xml module

2017-05-16 Thread huizhe wang
Hi Jon, Looks good. Thanks again! -Joe On 5/16/2017 3:27 PM, Jonathan Gibbons wrote: Please review these fixes to update the public doc comments in the java.xml module for HTML 5. Webrev: http://cr.openjdk.java.net/~jjg/8180385/webrev.02/ API: http://cr.openjdk.java.net/~jjg/8180385/api.02/

Re: RFR: 8180385: fix HTML issues in java.xml module

2017-05-16 Thread Lance Andersen
Hi Jon src/java.xml/share/classes/javax/xml/namespace/NamespaceContext.java - Was there a reason you omitted {@code getNamespaceURI(prefix)} when creating the caption? Looks pretty good otherwise > On May 16, 2017, at 6:27 PM, Jonathan Gibbons > wrote: > > Please review these fixes to upd

RFR: 8180385: fix HTML issues in java.xml module

2017-05-16 Thread Jonathan Gibbons
Please review these fixes to update the public doc comments in the java.xml module for HTML 5. Webrev: http://cr.openjdk.java.net/~jjg/8180385/webrev.02/ API: http://cr.openjdk.java.net/~jjg/8180385/api.02/ -- Jon