RFR: 81820709 - Container Awareness JEP

Here is a first pass at an implementation of the Container Awareness JEP. This JEP adds an implementation of an internal API for the extraction of system metrics for processes running in Isolation Groups (Containers). The plan is to get the internal API integrated in JDK 11 with support for Lin

Re: RFR: 81820709 - Container Awareness JEP

On 4/3/18 10:09 PM, Bob Vandette wrote: WEBREV: http://cr.openjdk.java.net/~bobv/8182070/v01/webrev I reviewed the webrev and look okay in general. I will look through the javadoc next. Metrics.java 37 * 1. All processes, including the current process within a container. includes

Re: RFR: 81820709 - Container Awareness JEP

Hi Mandy, I’m finally getting back to your review of this change now that we’ve made some progress on creating tests. BTW: This Jira issue is now an RFE rather than a JEP (https://bugs.openjdk.java.net/browse/JDK-8203357 ) See comments below .

Re: RFR: 81820709 - Container Awareness JEP

On 5/23/18 7:39 AM, Bob Vandette wrote: Should this be an instance method? like cpuacct.getLongValue("cpuacct.usage”); > I did it this way in order to provide a centralized place to check for missing subsystems. The getLongValue method does the checking for all subsystems 137 if

Re: RFR: 81820709 - Container Awareness JEP

> On May 24, 2018, at 2:42 PM, mandy chung wrote: > > > > On 5/23/18 7:39 AM, Bob Vandette wrote: >>> Should this be an instance method? like >>> cpuacct.getLongValue("cpuacct.usage”); > > >> I did it this way in order to provide a centralized place to check >> for missing subsystems. The ge

Re: RFR: 81820709 - Container Awareness JEP

On 5/24/18 12:31 PM, Bob Vandette wrote: Yes, I saw that but wasn’t sure how new text that’s added to the launcher.properties file would get localized. Is there a process for getting this done? No action should be needed. Changes to .properties files are tracked and localized version will be