On Wed, 4 Nov 2020 10:13:59 GMT, Kim Barrett wrote:
>> Hello!
>>
>> As an IDE developer, I'm thinking about IDE inspection that may suggest the
>> new method. My idea is to suggest replacing every `ref.get() == obj` with
>> `ref.refersTo(obj)`. Is this a good idea or there are cases when `ref.
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
> `ref.refersTo(obj)`. Is this a good idea or there are cases when `ref.g
On Wed, 4 Nov 2020 09:31:13 GMT, Tagir F. Valeev wrote:
>> The API looks good, thanks for getting this in.
>
> Hello!
>
> As an IDE developer, I'm thinking about IDE inspection that may suggest the
> new method. My idea is to suggest replacing every `ref.get() == obj` with
> `ref.refersTo(obj)
On Wed, 28 Oct 2020 15:56:48 GMT, Alan Bateman wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve wording in refersTo javadoc
>
> The API looks good, thanks for getting this in.
Hello!
As an IDE developer, I'
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
On Wed, 28 Oct 2020 08:54:31 GMT, Peter Levart wrote:
>> Some thoughts regarding the parameter type of refersTo. Summary: I think
>> `refersTo(T)` is fine and that we don't want to change it to
>> `refersTo(Object)`.
>>
>> I don't think we have a migration issue similar to generifying collecti
On Wed, 28 Oct 2020 03:46:55 GMT, Stuart Marks wrote:
> Some thoughts regarding the parameter type of refersTo. Summary: I think
> `refersTo(T)` is fine and that we don't want to change it to
> `refersTo(Object)`.
>
I agree that we don't have a migration problem here that collections had. So
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
On Sat, 24 Oct 2020 22:22:56 GMT, Peter Levart wrote:
>> Reference instances should not be leaked and so I don't see very common that
>> caller of `Reference::get` does not know the referent's type. It also
>> depends on the `refersTo` check against `null` vs an object. Any known use
>> cas
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote:
>> I just want to note that if you have a `Reference ref` at hand,
>> you can not just do:
>> Referemce r = (Reference) ref;
>> ...since those generic types are not related. You have to do something like:
>>
>> @SuppressWarnings({"unchecked",
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote:
>> I just want to note that if you have a `Reference ref` at hand,
>> you can not just do:
>> Referemce r = (Reference) ref;
>> ...since those generic types are not related. You have to do something like:
>>
>> @SuppressWarnings({"unchecked",
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
On Wed, 21 Oct 2020 02:55:49 GMT, David Holmes wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve wording in refersTo javadoc
>
> Update looks good. Need to reflect the change in the CSR.
>
> Thanks.
> David
On Wed, 21 Oct 2020 02:28:30 GMT, Kim Barrett wrote:
>> Finally returning to this review that was started in April 2020. I've
>> recast it as a github PR. I think the security concern raised by Gil
>> has been adequately answered.
>> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-A
> Finally returning to this review that was started in April 2020. I've
> recast it as a github PR. I think the security concern raised by Gil
> has been adequately answered.
> https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-April/029203.html
> https://mail.openjdk.java.net/pipermail/
15 matches
Mail list logo
