Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Brian Burkhalter
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Rewording repetitive phrase Marked as reviewed b

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Lance Andersen
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Rewording repetitive phrase Marked as reviewed b

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-23 Thread Iris Clark
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Rewording repetitive phrase Marked as reviewed b

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Rewording repetitive phrase - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 21:30:01 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 758: > >> 756: *group just a

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 20:22:04 GMT, Pavel Rappo wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 833: > >> 831: * Comments mode

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Lance Andersen
On Wed, 21 Jul 2021 21:25:18 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > delete errant line src/java.base/share/classes/j

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: delete errant line - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files - new: ht

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Iris Clark
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Changes match corresponding, approved CSR. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Naoto Sato
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Joe Darcy
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4618

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-07-21 Thread Pavel Rappo
On Mon, 28 Jun 2021 20:50:42 GMT, Ian Graves wrote: > 8199594: Add doc describing how (?x) ignores spaces in character classes src/java.base/share/classes/java/util/regex/Pattern.java line 833: > 831: * Comments mode can also be enabled via the embedded flag > 832: * expression {@cod

RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-06-28 Thread Ian Graves
8199594: Add doc describing how (?x) ignores spaces in character classes - Commit messages: - Updating documentation on comments mode and character class whitespace Changes: https://git.openjdk.java.net/jdk/pull/4618/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4618&

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v3]

2021-04-21 Thread Ian Graves
> Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking wording and placement - Changes: - all: https://git.o

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-21 Thread Ian Graves
On Wed, 21 Apr 2021 02:56:12 GMT, Stuart Marks wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding differences to Perl 5 note > > A few minor wording adjustments. Please update the CSR accordingly and I'll > revi

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-20 Thread Stuart Marks
On Mon, 19 Apr 2021 22:12:30 GMT, Ian Graves wrote: >> Clarifying note on comments mode to explicitly note that whitespace within >> character classes is ignored. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Adding differ

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-19 Thread Ian Graves
> Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding differences to Perl 5 note - Changes: - all: https://gi

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-04-19 Thread Ian Graves
On Mon, 19 Apr 2021 20:43:26 GMT, Ian Graves wrote: > Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Will put a /csr in to be safe. - PR: https://git.openjdk.java.net/jdk/pull/3577

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-04-19 Thread Brian Burkhalter
On Mon, 19 Apr 2021 20:43:26 GMT, Ian Graves wrote: > Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Looks all right. Probably a CSR is in order. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/j

RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-04-19 Thread Ian Graves
Clarifying note on comments mode to explicitly note that whitespace within character classes is ignored. - Commit messages: - Note about comments mode and character class whitespace Changes: https://git.openjdk.java.net/jdk/pull/3577/files Webrev: https://webrevs.openjdk.java.net/