Re: RFR: 8201650: Move iteration order randomization of unmodifiable Set and Map to iterators

2018-04-28 Thread Claes Redestad
Hi Stuart, On 2018-04-28 02:37, Stuart Marks wrote: Hi Claes, I finally got a chance to look at this. Overall looks fine. Although the randomness is "weaker" iterating in both directions will, I think, still have the desired effect of flushing out order dependencies. thanks, glad you

Re: RFR: 8201650: Move iteration order randomization of unmodifiable Set and Map to iterators

2018-04-27 Thread Stuart Marks
On 4/18/18 8:20 AM, Claes Redestad wrote: please review this change that moves the use of SALT to iterator creation, which would allow for certain startup optimizations in the future. Bug: https://bugs.openjdk.java.net/browse/JDK-8201650 Webrev:

Re: RFR: 8201650: Move iteration order randomization of unmodifiable Set and Map to iterators

2018-04-18 Thread Jiangli Zhou
Hi Claes, Moving the use of SALT to iterator creation is a great idea! You change looks really good. Thanks for making the change! Jiangli > On Apr 18, 2018, at 8:20 AM, Claes Redestad wrote: > > Hi, > > please review this change that moves the use of SALT to

RFR: 8201650: Move iteration order randomization of unmodifiable Set and Map to iterators

2018-04-18 Thread Claes Redestad
Hi, please review this change that moves the use of SALT to iterator creation, which would allow for certain startup optimizations in the future. Bug: https://bugs.openjdk.java.net/browse/JDK-8201650 Webrev: http://cr.openjdk.java.net/~redestad/8201650/open.00/ This does make the randomness