Re: RFR: 8205438: Re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java

2018-06-27 Thread James Laskey
We went through the same exercise with jjs. Tough coming up with shebang tests that worked on all platforms. Shebang args vs command line args was a nightmare. Sent from my iPhone > On Jun 27, 2018, at 6:02 PM, mandy chung wrote: > > Looks good. It's amazing to find out 3 different behavior

Re: RFR: 8205438: Re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java

2018-06-27 Thread mandy chung
Looks good. It's amazing to find out 3 different behavior on these 3 platforms. Mandy On 6/27/18 1:37 PM, Jonathan Gibbons wrote: Please review a test fix to re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java . The test cases for invoking the source launcher via the shebang

RFR: 8205438: Re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java

2018-06-27 Thread Jonathan Gibbons
Please review a test fix to re-enable shebang tests in test/jdk/tools/launchers/SourceMode.java . The test cases for invoking the source launcher via the shebang mechanism have been disabled because they were adversely affected by the very long pathnames on our internal test infastructure, cau