Re: RFR: 8211382 ISO2022JP and GB18030 NIO converter issues

2018-10-31 Thread Roger Riggs
+1, looks fine If you need a sponsor, I can. Regards, Roger On 10/30/18 1:32 PM, Ichiroh Takiguchi wrote: Hello. Additional reviewer is required. It's typo issue as Sherman explained. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-03 07:01, Xueming Shen wrote: +1 -Sherman btw, since

Re: RFR: 8211382 ISO2022JP and GB18030 NIO converter issues

2018-10-30 Thread Ichiroh Takiguchi
Hello. Additional reviewer is required. It's typo issue as Sherman explained. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-10-03 07:01, Xueming Shen wrote: +1 -Sherman btw, since gb18030.decodeArrayLoop() is right I would assume it's just a "typo" in decodeBufferLoop() On 10/2/18, 2:21

Re: RFR: 8211382 ISO2022JP and GB18030 NIO converter issues

2018-10-02 Thread Xueming Shen
+1 -Sherman btw, since gb18030.decodeArrayLoop() is right I would assume it's just a "typo" in decodeBufferLoop() On 10/2/18, 2:21 AM, Ichiroh Takiguchi wrote: Hello, IBM would like to contribute NIO converter patch to OpenJDK project. Bug:https://bugs.openjdk.java.net/browse/JDK-821138

RFR: 8211382 ISO2022JP and GB18030 NIO converter issues

2018-10-02 Thread Ichiroh Takiguchi
Hello, IBM would like to contribute NIO converter patch to OpenJDK project. Bug:    https://bugs.openjdk.java.net/browse/JDK-8211382 Change: https://cr.openjdk.java.net/~itakiguchi/8211382/webrev.00/ Issue: ISO2022JP decoder and GB18030 decoder (for decodeBufferLoop()) have code range definitio