Re: RFR: 8213741: Consolidate Object and String Stringifiers

2018-11-12 Thread Claes Redestad
On 2018-11-12 16:56, Aleksey Shipilev wrote: On 11/12/2018 03:24 PM, Claes Redestad wrote: Webrev: http://cr.openjdk.java.net/~redestad/8213741/jdk.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8213741 Looks good to me. Thanks! If anyone is wondering: With this and other recent improveme

Re: RFR: 8213741: Consolidate Object and String Stringifiers

2018-11-12 Thread Aleksey Shipilev
On 11/12/2018 03:24 PM, Claes Redestad wrote: > Webrev: http://cr.openjdk.java.net/~redestad/8213741/jdk.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8213741 Looks good to me. *) Not sure this is significantly better than String.valueOf(String.valueOf(s)), as original comment suggests: 1

RFR: 8213741: Consolidate Object and String Stringifiers

2018-11-12 Thread Claes Redestad
Hi, following up on JDK-8213478[1], this patch consolidates the use of "Stringifiers" in StringConcatFactory to use a single Stringifier for all String and Object arguments. This has the effect that repeated filters become much more common with the default implementation, and can reduce the n