Re: RFR: 8215000: tools/launcher/JliLaunchTest.java fails on Windows

2018-12-12 Thread Henry Jen
Duh, should be v==null. Thanks for catching it. Cheers, Henry > On Dec 12, 2018, at 10:50 AM, Mandy Chung wrote: > > Brent is right since k is the given key and non-null. Although it does not > cause any issue as it only adds an empty element in the path, we should fix > it in this patch. >

Re: RFR: 8215000: tools/launcher/JliLaunchTest.java fails on Windows

2018-12-12 Thread Mandy Chung
Brent is right since k is the given key and non-null.  Although it does not cause any issue as it only adds an empty element in the path, we should fix it in this patch. Mandy On 12/12/18 10:30 AM, Brent Christian wrote: Hi, Shouldn't the lambdas be checking for v == null, rather than k ==

Re: RFR: 8215000: tools/launcher/JliLaunchTest.java fails on Windows

2018-12-12 Thread Brent Christian
Hi, Shouldn't the lambdas be checking for v == null, rather than k == null? -Brent On 12/12/18 9:36 AM, Henry Jen wrote: Hi, Can I get a review of following patch? Looks like the assumption test jdk will be in PATH is simply not true, jtreg doesn’t do that. Also, this patch make sure the

RFR: 8215000: tools/launcher/JliLaunchTest.java fails on Windows

2018-12-12 Thread Henry Jen
Hi, Can I get a review of following patch? Looks like the assumption test jdk will be in PATH is simply not true, jtreg doesn’t do that. Also, this patch make sure the JDK to be tested is first in the search path. Cheers, Henry diff -r 241b8151b6b6 test/jdk/tools/launcher/JliLaunchTest.java