Re: [PING] RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp

2019-03-18 Thread Andrew Dinn
On 18/03/2019 10:06, Severin Gehwolf wrote: > Could I get a review from an OpenJDK Reviewer for this, please? Bob is > already OK with it. Yes, this is fine. Reviewed. regards, Andrew Dinn ---

Re: [PING] RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp

2019-03-18 Thread Severin Gehwolf
Hi, Could I get a review from an OpenJDK Reviewer for this, please? Bob is already OK with it. Thanks, Severin On Thu, 2019-03-14 at 13:58 -0400, Bob Vandette wrote: > The change looks good. Thanks for fixing this. > > I’d send this to core-libs (cc’d). > > Bob. > > > > On Mar 14, 2019, at

Re: RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp

2019-03-14 Thread Severin Gehwolf
On Thu, 2019-03-14 at 13:58 -0400, Bob Vandette wrote: > The change looks good. Thanks for fixing this. Thanks for the review, Bob! Cheers, Severin > I’d send this to core-libs (cc’d). > > Bob. > > > > On Mar 14, 2019, at 12:51 PM, Severin Gehwolf > > wrote: > > > > Hi, > > > > I'm not su

Re: RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp

2019-03-14 Thread Bob Vandette
The change looks good. Thanks for fixing this. I’d send this to core-libs (cc’d). Bob. > On Mar 14, 2019, at 12:51 PM, Severin Gehwolf wrote: > > Hi, > > I'm not sure what the right list for Metrics.java[1] is. Assuming it's > serviceability-dev: > > Please review this one-liner for for Su