Re: RFR: 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs

2019-03-21 Thread serguei.spit...@oracle.com
Hi Bob, It looks good to me. Thanks, Serguei On 3/21/19 10:12, Bob Vandette wrote: Please review this fix for a container test that fails on some Linux distributions. The test fails to see the Memory Fail count metric value increase. This is caused by the fact that we are allowing ergonom

Re: RFR: 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs

2019-03-21 Thread Severin Gehwolf
Hi Bob, On Thu, 2019-03-21 at 13:12 -0400, Bob Vandette wrote: > WEBREV: > > http://cr.openjdk.java.net/~bobv/8220674/webrev/ This looks good to me. Thanks for fixing it! I'm not a Reviewer, though. Cheers, Severin

RFR: 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs

2019-03-21 Thread Bob Vandette
Please review this fix for a container test that fails on some Linux distributions. The test fails to see the Memory Fail count metric value increase. This is caused by the fact that we are allowing ergonomics to select the amount of Heap size. This size varies depending on the amount of fre