Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

2019-05-09 Thread Bob Vandette
> On May 9, 2019, at 1:47 PM, Roger Riggs wrote: > > Hi Bob, > > jdk/internal/platform/cgroupv1/SubSystem.java: > 64: Is that the same as cgroupPath.startsWith(root)? That might be slightly > more readable. > Sure, that works. I’ll change it. > Regardless, that looks fine. > Thanks,

Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

2019-05-09 Thread Roger Riggs
Hi Bob, jdk/internal/platform/cgroupv1/SubSystem.java: 64: Is that the same as cgroupPath.startsWith(root)?  That might be slightly more readable. Regardless, that looks fine. Roger On 05/08/2019 10:24 AM, Bob Vandette wrote: Thanks Misha! Could I get a “Review” from someone in core libs,

Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

2019-05-08 Thread Bob Vandette
Thanks Misha! Could I get a “Review” from someone in core libs, please? Bob. > On May 7, 2019, at 8:49 PM, mikhailo.seledt...@oracle.com wrote: > > Changes look good to me, > > Misha > > > On 5/7/19 5:56 AM, Bob Vandette wrote: >> Please review this change to the Container Metrics

Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

2019-05-07 Thread mikhailo . seledtsov
Changes look good to me, Misha On 5/7/19 5:56 AM, Bob Vandette wrote: Please review this change to the Container Metrics implementation. Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct the parsing of of the /proc/self/mountinfo file but corresponding changes to the

RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

2019-05-07 Thread Bob Vandette
Please review this change to the Container Metrics implementation. Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct the parsing of of the /proc/self/mountinfo file but corresponding changes to the Metrics API and Container tests shou,d have been done to match this change.