Thank you Lance. I pushed it with your suggestion worked in.
From: Lance Andersen
Sent: Donnerstag, 16. Mai 2019 15:44
To: Langer, Christoph
Cc: core-libs-dev ; nio-dev
; Alan Bateman
Subject: Re: RFR: 876: (zipfs) Refactoring and cleanups to prepare for
JDK-8213031
Hi Christoph,
Thank
Hi Christoph,
Thank you for the update.
Looks good. One minor suggestion below that you can take care of before you
push without a new webrev.
Best,
Lance
> On May 15, 2019, at 9:25 AM, Langer, Christoph
> wrote:
>
> Hi Lance,
>
> thanks for the quick turnaround. I tried to address your f
Hi Lance,
thanks for the quick turnaround. I tried to address your findings. Please find
the new webrev here: http://cr.openjdk.java.net/~clanger/webrevs/876.3/
> o FindEND()
> • I know that endsub and comlen fields are not currently used by Zip FS but
> given they are valid fields in the h
Hi Chistoph,
> On May 14, 2019, at 8:38 AM, Langer, Christoph
> wrote:
>
> Hi Lance,
>
>> Thank you for taking this on.
>
> Thank you for reviewing! Unfortunately you didn't look at my latest
> edition... (http://cr.openjdk.java.net/~clanger/webrevs/876.2/)
Sorry, must have clicked on t
Hi Lance,
> Thank you for taking this on.
Thank you for reviewing! Unfortunately you didn't look at my latest edition...
(http://cr.openjdk.java.net/~clanger/webrevs/876.2/)
In v2 I took back the modification of the hierarchy of classes IndexNode and
Entry so it should be a bit easier to r
> got from Lance.
>
> Please get me some reviews 😊
>
> Thanks
> Christoph
>
>
> From: Langer, Christoph
> Sent: Dienstag, 30. April 2019 11:54
> To: core-libs-dev ; nio-dev
> ; Alan Bateman ; Lance
> Andersen
> Subject: RE: RFR: 876: (zipfs)
io-dev mailto:nio-...@openjdk.java.net>>; Alan
Bateman mailto:alan.bate...@oracle.com>>; Lance
Andersen mailto:lance.ander...@oracle.com>>
Subject: RE: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for
JDK-8213031
Hi,
ping 😊
I’ve rebased this change after the late
va.net>>; Alan
Bateman mailto:alan.bate...@oracle.com>>; Lance
Andersen mailto:lance.ander...@oracle.com>>
Subject: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for
JDK-8213031
Hi,
working on JDK-8213031 to add posix file permission support for the zipfs, I
t
Great, thank you. This one is a bit larger and will probably need a few
iterations…
From: Lance Andersen
Sent: Freitag, 26. April 2019 18:45
To: Langer, Christoph
Cc: core-libs-dev ; nio-dev
; Alan Bateman
Subject: Re: RFR: 876: (zipfs) Refactoring and cleanups to prepare for
JDK
//cr.openjdk.java.net/~clanger/webrevs/876.1/>
>
> The jtreg tests for zipfs are all passing.
>
> Thanks
> Christoph
>
> From: Langer, Christoph
> Sent: Donnerstag, 11. April 2019 16:06
> To: core-libs-dev ; nio-dev
> ; Alan Bateman ; Lance
> Andersen
>
://cr.openjdk.java.net/~clanger/webrevs/876.1/
The jtreg tests for zipfs are all passing.
Thanks
Christoph
From: Langer, Christoph
Sent: Donnerstag, 11. April 2019 16:06
To: core-libs-dev ; nio-dev
; Alan Bateman ; Lance
Andersen
Subject: RFR: 876: (zipfs) Refactoring and cleanups to prepare for
Hi,
working on JDK-8213031 to add posix file permission support for the zipfs, I
thought it makes sense to factor out some of the changes into a separate
change. Those changes reorganize and clean up some parts of the code which I
think makes sense in any case.
Please review:
Bug: https://bugs
12 matches
Mail list logo
