Much better now. One nit: label "freedata" at line 236 should not be
indented.
As to the fastpath candidate zones, I was just curious. UTC/GMT is fine
by me.
Naoto
On 9/13/19 1:32 AM, Seán Coffey wrote:
Thanks for the review Naoto. The edits certainly did need some tidying
up. Comments inli
Thanks Roger,
I've reverted the header file changes then and added this to the .c file:
@@ -42,6 +42,8 @@
#include "jvm.h"
#include "TimeZone_md.h"
+static char *isFileIdentical(char* buf, size_t size, char *pathname);
+
#define SKIP_SPACE(p) while (*p == ' ' || *p == '\t') p++;
#define
Hi Sean,
The declaration can be up in the _md.c file to satify the compiler about
forward declarations.
$.02, Roger
On 9/13/19 4:34 AM, Seán Coffey wrote:
Thanks for the review Roger. I run into compiler issues if I don't
declare the new function in the header file.
/ws/jdk-jdk/open/src/ja
Thanks for the review Roger. I run into compiler issues if I don't
declare the new function in the header file.
/ws/jdk-jdk/open/src/java.base/unix/native/libjava/TimeZone_md.c:143:18:
error: implicit declaration of function ‘isFileIdentical’
[-Werror=implicit-function-declaration]
Thanks for the review Naoto. The edits certainly did need some tidying
up. Comments inline.
On 12/09/2019 17:42, naoto.s...@oracle.com wrote:
Hi Seán,
I like your approach to provide the fast path to determine the system
time zone. One general question is, is UTC/GMT the right set of fast
pa
Hi Sean,
In addition to Naoto's comments.
The change to TimeZone_md.h should not be needed.
A 'static' declaration doesn't need to be visible outside its source file.
Roger
On 9/12/19 12:42 PM, naoto.s...@oracle.com wrote:
Hi Seán,
I like your approach to provide the fast path to determine
Hi Seán,
I like your approach to provide the fast path to determine the system
time zone. One general question is, is UTC/GMT the right set of fast
path candidates? Should we add some more common ones?
Other comments to the code:
TimeZone_md.c
- Should fast path search come after "dir" vali
The current algorithm for determining the default timezone on (non-AIX)
unix systems goes something like :
1. If TZ environment variable is defined, use it
2. else if /etc/timezone exists, use the value contained within it
3. else if /etc/localtime exists and is a symbolic link, use the name
po
