Re: RFR: 8229899: java.io.File.isInvalid() is racy

2019-08-20 Thread Arthur Eubanks
Thanks for the reviews! On Tue, Aug 20, 2019 at 8:21 AM Martin Buchholz wrote: > Looks good to me. > > On Mon, Aug 19, 2019 at 4:15 PM Arthur Eubanks > wrote: > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8229899 >> Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/ >> >>

Re: RFR: 8229899: java.io.File.isInvalid() is racy

2019-08-20 Thread Martin Buchholz
Looks good to me. On Mon, Aug 19, 2019 at 4:15 PM Arthur Eubanks wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8229899 > Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/ > > final boolean isInvalid() { > if (status == null) { > status = (this.path.

Re: RFR: 8229899: java.io.File.isInvalid() is racy

2019-08-20 Thread Alan Bateman
On 20/08/2019 00:14, Arthur Eubanks wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229899 Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/ final boolean isInvalid() { if (status == null) { status = (this.path.indexOf('\u') < 0) ? PathStatus.CH

Re: RFR: 8229899: java.io.File.isInvalid() is racy

2019-08-20 Thread Aleksey Shipilev
On 8/20/19 1:14 AM, Arthur Eubanks wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8229899 > Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/ Right, the new code turns data race benign. In older code, the first read of "status" could have returned "!null", while the second r

RFR: 8229899: java.io.File.isInvalid() is racy

2019-08-19 Thread Arthur Eubanks
Bug: https://bugs.openjdk.java.net/browse/JDK-8229899 Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/ final boolean isInvalid() { if (status == null) { status = (this.path.indexOf('\u') < 0) ? PathStatus.CHECKED