Re: RFR: 8231355: Remove unused utility methods in libjava

2019-10-08 Thread Alan Bateman
On 07/10/2019 19:38, Claes Redestad wrote: Hi, please review this patch which removes unused methods and redundant aliases from jni_util and friends in libjava. There's one affected call site in the hotspot runtime code, otherwise this is mainly a java.base-internal cleanup. Bug:    https://bu

Re: RFR: 8231355: Remove unused utility methods in libjava

2019-10-07 Thread John Rose
On Oct 7, 2019, at 11:38 AM, Claes Redestad wrote: > > Bug:https://bugs.openjdk.java.net/browse/JDK-8231355 > > Webrev: http://cr.openjdk.java.net/~redestad/8231355/open.00/ > > > Tes

Re: RFR: 8231355: Remove unused utility methods in libjava

2019-10-07 Thread David Holmes
Hi Claes, This all looks good to me! Thanks, David On 8/10/2019 4:38 am, Claes Redestad wrote: Hi, please review this patch which removes unused methods and redundant aliases from jni_util and friends in libjava. There's one affected call site in the hotspot runtime code, otherwise this is m

RFR: 8231355: Remove unused utility methods in libjava

2019-10-07 Thread Claes Redestad
Hi, please review this patch which removes unused methods and redundant aliases from jni_util and friends in libjava. There's one affected call site in the hotspot runtime code, otherwise this is mainly a java.base-internal cleanup. Bug:https://bugs.openjdk.java.net/browse/JDK-8231355 Webre