Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

2021-04-06 Thread Alexander Matveev
On Wed, 7 Apr 2021 00:22:14 GMT, Alexey Semenyuk wrote: >> Use value of `--icon` jpackage CLI option to set icon for exe installers. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Fix

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

2021-04-06 Thread Andy Herrick
On Wed, 7 Apr 2021 00:22:14 GMT, Alexey Semenyuk wrote: >> Use value of `--icon` jpackage CLI option to set icon for exe installers. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Fix

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v3]

2021-04-06 Thread Alexey Semenyuk
> Use value of `--icon` jpackage CLI option to set icon for exe installers. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Fix AppImagePackageTest.testEmpty(true) failure - Changes: - all:

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v2]

2021-04-06 Thread Andy Herrick
On Tue, 6 Apr 2021 18:01:02 GMT, Alexey Semenyuk wrote: >> Use value of `--icon` jpackage CLI option to set icon for exe installers. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Make --icon option applicable in

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers [v2]

2021-04-06 Thread Alexey Semenyuk
> Use value of `--icon` jpackage CLI option to set icon for exe installers. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Make --icon option applicable in installer mode - Changes: - all:

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

2021-04-06 Thread Alexey Semenyuk
On Tue, 6 Apr 2021 14:45:26 GMT, Andy Herrick wrote: >> Marked as reviewed by herrick (Reviewer). > > One question - > ICON is only a valid option for creating app launcher. If creating an > installer using --app-image option it would not be a vlid option. > Does this change imply we should

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

2021-04-06 Thread Andy Herrick
On Tue, 6 Apr 2021 14:39:07 GMT, Andy Herrick wrote: >> Use value of `--icon` jpackage CLI option to set icon for exe installers. > > Marked as reviewed by herrick (Reviewer). One question - ICON is only a valid option for creating app launcher. If creating an installer using --app-image

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

2021-04-06 Thread Andy Herrick
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk wrote: > Use value of `--icon` jpackage CLI option to set icon for exe installers. Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3347

Re: RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

2021-04-05 Thread Alexander Matveev
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk wrote: > Use value of `--icon` jpackage CLI option to set icon for exe installers. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/3347

RFR: 8236127: Use value of --icon CLI option to set icon for exe installers

2021-04-05 Thread Alexey Semenyuk
Use value of `--icon` jpackage CLI option to set icon for exe installers. - Commit messages: - 8236127: Use value of --icon CLI option to set icon for exe installers Changes: https://git.openjdk.java.net/jdk/pull/3347/files Webrev: