This is a GUI test, and it should be `@headful`.
Additional testing:
- [x] Test still runs in default, and does not run with `!headful`
-
Commit messages:
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/5544/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5544&ra
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Marking the test headful if OK - but should `headful` also be added to the keys
in `test/la
On Thu, 16 Sep 2021 09:39:25 GMT, Jan Lahoda wrote:
> Marking the test headful if OK - but should `headful` also be added to the
> keys in `test/langtools/TEST.ROOT`? (I am not quite sure how that works.)
AFAICS, this test is in `jdk`, so it is covered by `jdk/TEST.ROOT`. I tested it
with and
On Thu, 16 Sep 2021 09:47:16 GMT, Jan Lahoda wrote:
>> This is a GUI test, and it should be `@headful`.
>>
>> Additional testing:
>> - [x] Test still runs in default, and does not run with `!headful`
>
> Ah, right, I thought it is a JShell test, but it is not. Sorry for the noise.
@lahodaj, wo
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Any takers? ;)
-
PR: https://git.openjdk.java.net/jdk/pull/5544
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Marked as reviewed by jlahoda (Reviewer).
-
PR: https://git.openjdk.java.net/j
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/5544
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote:
> This is a GUI test, and it should be `@headful`.
>
> Additional testing:
> - [x] Test still runs in default, and does not run with `!headful`
Well .. since our test framework doesn't run whatever test group this is in on
headful syst
On Wed, 22 Sep 2021 23:19:50 GMT, Phil Race wrote:
> You'd need to add it to the desktop test group.
Right. See #5648.
-
PR: https://git.openjdk.java.net/jdk/pull/5544
