Hi Aleksei,
If that solves the issue, then LGTM!
best regards,
-- daniel
On 07/05/2020 14:57, Aleks Efimov wrote:
Hi Daniel,
As a follow-up to our off-list discussion, I've updated the
generateUnseenPort method:
a) Added comment to be more specific about the number of times it is called
Hi Daniel,
As a follow-up to our off-list discussion, I've updated the
generateUnseenPort method:
a) Added comment to be more specific about the number of times it is called
b) The port range has been extended to [, PortConfig.getUpper())
Webrev with new version:
Hi Aleksei,
I agree with the general idea. However, the method:
215 private static int generateUnseenPort() {
216 int port;
217 do {
218 port = + RND.nextInt(1000);
219 } while (SEEN_PORTS.contains(port));
220 SEEN_PORTS.add(port);
221
Hi,
LdapDnsProviderTest test expects to have no services running on
port on test machine. That could cause it to fail intermittently due to
unexpected exception message thrown by LDAP client, i.e. timeout or
disconnect instead of expected connection refusal.
The proposed fix tries to
