Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 15:18:58 GMT, Raffaello Giulietti wrote: >> I think the change looks good. >> >> Before the project was on GitHub, there was a change to the test posted in >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068504.html >> to address the comment in >> htt

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-19 Thread Raffaello Giulietti
On Sat, 17 Oct 2020 00:16:57 GMT, Brian Burkhalter wrote: >> Hello, >> >> a reminder that this issue has not been formally reviewed. >> Estimated time: 10-15 min with "Hacker's delight" on the desk. >> >> Greetings >> Raffaello > > I think the change looks good. > > Before the project was on G

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-16 Thread Brian Burkhalter
On Wed, 14 Oct 2020 14:20:11 GMT, Raffaello Giulietti wrote: >> Hello >> >> this is a gentle reminder that this issue still needs a more formal review. >> >> Greetings >> Raffaello > > Hello, > > a reminder that this issue has not been formally reviewed. > Estimated time: 10-15 min with "Hack

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-10-14 Thread Raffaello Giulietti
On Thu, 24 Sep 2020 15:33:01 GMT, Raffaello Giulietti wrote: >> @shipilev I agree, but that's the title chosen by the reporter of the JBS >> issue. Not sure I can edit it without >> impacting bots and tools. > > Hello > > this is a gentle reminder that this issue still needs a more formal revi

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-09-24 Thread Raffaello Giulietti
On Wed, 9 Sep 2020 07:38:38 GMT, Raffaello Giulietti wrote: >> Since this patch does not involve adding the intrinsic, maybe drop "(Needs >> to be intrinsic)" from the synopsis? > > @shipilev I agree, but that's the title chosen by the reporter of the JBS > issue. Not sure I can edit it withou

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-09-09 Thread rgiulietti
On Wed, 9 Sep 2020 06:25:40 GMT, Aleksey Shipilev wrote: >> rgiulietti has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8238669: Long.divideUnsigned is extremely slow for certain values (Needs >> to be Intrinsic) >> >> Added helpful

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-09-08 Thread Aleksey Shipilev
On Tue, 8 Sep 2020 22:05:13 GMT, rgiulietti wrote: >> This is a follow-up of the Mercurial-based workflow initiated on the >> core-lib-devs mailing list [0]. Not sure if this >> one is strictly necessary or if the patches sent on the list are sufficient. >> Anyway, I exploit this PR as a test

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-09-08 Thread rgiulietti
On Tue, 8 Sep 2020 20:42:41 GMT, rgiulietti wrote: >> src/java.base/share/classes/java/lang/Long.java line 1697: >> >>> 1695: final long q = (dividend >>> 1) / divisor << 1; >>> 1696: final long r = dividend - q * divisor; >>> 1697: return r - (~(r - divisor)

Re: RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic) [v2]

2020-09-08 Thread rgiulietti
> This is a follow-up of the Mercurial-based workflow initiated on the > core-lib-devs mailing list [0]. Not sure if this > one is strictly necessary or if the patches sent on the list are sufficient. > Anyway, I exploit this PR as a test ;-) > [0] > https://mail.openjdk.java.net/pipermail/core-