RE: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-25 Thread Baesken, Matthias
Hi Severin, makes sense ! Maybe you could adjust the comment and add a bit of info about this . I do not need to see a new webrev . Best regards, Matthias > > What you are seeing here is a hybrid system[1]. My workstation is > hybrid as well. Legacy and hybrid systems are being detected as c

Re: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-25 Thread Severin Gehwolf
Hi Matthias, On Tue, 2020-02-25 at 14:01 +, Baesken, Matthias wrote: > Hi Severin, 8239559/02 looks generally good . Thanks for the review! > However I wonder about this : > > I have a SLES15 aarch64 system with these settings : > > more /proc/cgroups > #subsys_name hierarchy

RE: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-25 Thread Baesken, Matthias
Hi Severin, 8239559/02 looks generally good . However I wonder about this : I have a SLES15 aarch64 system with these settings : more /proc/cgroups #subsys_namehierarchy num_cgroups enabled cpuset 6 1 1 cpu 8 1 1 cpuacct 8 1 1 blkio

Re: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-24 Thread Severin Gehwolf
On Mon, 2020-02-24 at 10:28 -0500, Bob Vandette wrote: > > > If you don’t have access to the information required to get metrics, I > > > just assumed that > > > you would return NULL in CgroupSubsystemFactory.create() rather than > > > making the > > > assumption that it works only to fail later

RE: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-24 Thread Baesken, Matthias
Hi, regarding RHEL 6 this webpage says it is not supported, only on RHEL 7 + . https://access.redhat.com/solutions/1378023 Regarding SUSE Linux (SLES) we run docker on SLES12 and higher ( I don't think docker is supported on SLES11 but not 100% sure ). Best regards, Matthias > >

Re: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-24 Thread Bob Vandette
> On Feb 24, 2020, at 5:36 AM, Severin Gehwolf wrote: > > Hi Bob, > > Note: I've changed the bug title to be version-less. This is really an > issue in the detection logic irrespective of cgroup version in use. > > On Fri, 2020-02-21 at 10:12 -0500, Bob Vandette wrote: >>> On Feb 21, 2020, a

Re: RFR: 8239559: Cgroups: Incorrect detection logic on some systems

2020-02-24 Thread Severin Gehwolf
Hi Bob, Note: I've changed the bug title to be version-less. This is really an issue in the detection logic irrespective of cgroup version in use. On Fri, 2020-02-21 at 10:12 -0500, Bob Vandette wrote: > > On Feb 21, 2020, at 9:30 AM, Severin Gehwolf wrote: > > > > Hi Bob, > > > > On Fri, 2020