Re: RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-24 Thread Severin Gehwolf
Hi Matthias, On Mon, 2020-02-24 at 11:05 +, Baesken, Matthias wrote: > Hi Severin, I'll put your patch into our internal build/test queue . > > Additionally I can confirm that the error I reported last week when running > jtreg tests : > > > > > > ./jtregojdk.sh tools/jpackage > >

RE: RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-24 Thread Baesken, Matthias
Hi Severin, I'll put your patch into our internal build/test queue . Additionally I can confirm that the error I reported last week when running jtreg tests : > > > ./jtregojdk.sh tools/jpackage > > > java.lang.InternalError: java.lang.reflect.InvocationTargetException >

Re: RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-21 Thread Bob Vandette
> On Feb 21, 2020, at 9:30 AM, Severin Gehwolf wrote: > > Hi Bob, > > On Fri, 2020-02-21 at 09:11 -0500, Bob Vandette wrote: >> Severin, >> >> Don’t we need the contents of /proc/self/mountinfo in order to construct the >> path to the cgroup controllers? > > There is only one for unified

Re: RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-21 Thread Severin Gehwolf
Hi Bob, On Fri, 2020-02-21 at 09:11 -0500, Bob Vandette wrote: > Severin, > > Don’t we need the contents of /proc/self/mountinfo in order to construct the > path to the cgroup controllers? There is only one for unified (cgroups v2), but yes it's beeing used. See

Re: RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-21 Thread Bob Vandette
Severin, Don’t we need the contents of /proc/self/mountinfo in order to construct the path to the cgroup controllers? On Thu, 2020-02-20 at 14:50 +, Baesken, Matthias wrote: > Hi Severin, > > grep cgroup /proc/self/mountinfo > > returns nothing. > > Best Regards, Matthias >

RFR: 8239559: Cgroups v2: Incorrect detection logic on some systems

2020-02-21 Thread Severin Gehwolf
Hi, Could I please get a review of this fix to the detection heuristic of cgroup v1 vs cgroup v2? Matthias (in CC) discovered that on some old systems the JDK Metrics code throws InternalError caused by wrong detection logic when Metrics are being created on Linux. The reason for this is that