Re: RFR: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Looks good. Naoto On 2/27/20 6:00 AM, Ichiroh Takiguchi wrote: Hello Naoto. I appreciate your comments. And sorry for my easy mistake. Could you review the fix again ? Bug:    https://bugs.openjdk.java.net/browse/JDK-8239965 Change: https://cr.openjdk.java.net/~itakiguchi/8239965/webrev.01/

Re: RFR: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Hello Naoto. I appreciate your comments. And sorry for my easy mistake. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8239965 Change: https://cr.openjdk.java.net/~itakiguchi/8239965/webrev.01/ Thanks, Ichiroh Takiguchi On 2020-02-27 05:56, naoto.s...@oracle

Re: RFR: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Takiguchi-san, Some nits: - Please add 'noreg-self' to the jira issue. - Copyright year should be modified. - Add the bug number to '@bug' tag. Naoto On 2/26/20 10:03 AM, Ichiroh Takiguchi wrote: Hello. Could you review the fix ? Bug:    https://bugs.openjdk.java.net/browse/JDK-8239965 Chan

RFR: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8239965 Change: https://cr.openjdk.java.net/~itakiguchi/8239965/webrev.00/ Sorry for side effect. Test4625418.java should skip Cp943 and x-IBM943 should be skipped after JDK-8235834 [1] was integrated. [1] https