On Wed, 5 May 2021 11:05:11 GMT, Jan Lahoda wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
>> 1704:
>>
>>> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
>>> 1703: result = result & ~STRICTFP;
>>> 1704:
>>
>> Nitpick:
On Wed, 5 May 2021 18:03:54 GMT, Naoto Sato wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 290:
>
>> 288:
>> 28
On Wed, 5 May 2021 18:53:50 GMT, Joe Darcy wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
>> line 1769:
>>
>>> 1767: compiler.warn.strictfp=\
>>> 1768: as of release 17, all floating-point expressions are evaluated
>>> strictly and ''strictfp'' i
> 8244146: javac changes for JEP 306
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3831/files
- new: https://git.openjdk.java.net/jdk
On Wed, 5 May 2021 05:31:40 GMT, Srikanth Adayapalam
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
>
On Wed, 5 May 2021 17:56:09 GMT, Joe Darcy wrote:
>> 8244146: javac changes for JEP 306
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.
> 8244146: javac changes for JEP 306
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3831/files
- new: https://git.openjdk.java.net/jdk
On Wed, 5 May 2021 17:53:43 GMT, Joe Darcy wrote:
>> 8244146: javac changes for JEP 306
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Changes to `java.base` look fine. The other changes should be
On Wed, 5 May 2021 06:07:23 GMT, Srikanth Adayapalam
wrote:
>> 8244146: javac changes for JEP 306
>
> test/langtools/tools/javac/annotations/typeAnnotations/classfile/NestedLambdasCastedTest.java
> line 34:
>
>> 32: * @build toolbox.ToolBox toolbox.JavapTask
>> 33: * @run compile -source 16
On Wed, 5 May 2021 05:26:47 GMT, Srikanth Adayapalam
wrote:
>> 8244146: javac changes for JEP 306
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
> 1704:
>
>> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
>> 1703: result = re
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java line 170:
> 168:
> 169: allOptions.add("--should-stop=at=FLOW");
> 170: allOptions.add("-Xlint:unchecked,-strictfp");
I wonder if JSh
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
Overall, looks good other than the various minor issues called out.
I wonder if the tests would have turned out to be a good bit simpler if we
simply checked diagnostics against a golden file and skipped the
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 1326:
> 1324: private void warnOnExplicitStrictfp(DiagnosticPosition pos, JCTree
> tree) {
> 1325: DiagnosticPosition prevL
On 5/4/2021 10:30 PM, Srikanth Adayapalam wrote:
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
1704:
1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
1
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 228:
> 226: SEALED_CLASSES(JDK17, Fragments.FeatureSealedClasses,
> DiagKind.PLURAL),
> 227: // todo: will need to sup
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
line 1769:
> 1767: compiler.warn.strictfp=\
> 1768: as of release 17, all floating-point expressions are evaluated
> stri
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
1704:
> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source))
> 1703: result = result & ~STRICTFP;
> 1
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote:
> 8244146: javac changes for JEP 306
For core-libs, under JEP 306 strictfp would be a no-op under 17. Therefore, the
few uses of the strictfp modifier in the base module can be removed.
-
PR: https://git.openjdk.java.net/jdk/pull/3
18 matches
Mail list logo