Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-07-07 Thread Kim Barrett
> On Jul 7, 2020, at 9:59 AM, Erik Joelsson wrote: > > Doc changes look good. > > /Erik > > On 2020-07-06 18:10, Kim Barrett wrote: >> I just noticed that doc/building.{md,html} describes minimum toolchain >> versions, >> so also needs to be updated. Here’s the update, matching what’s now in

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-07-07 Thread Erik Joelsson
Doc changes look good. /Erik On 2020-07-06 18:10, Kim Barrett wrote: I just noticed that doc/building.{md,html} describes minimum toolchain versions, so also needs to be updated. Here’s the update, matching what’s now in the JEP: full: https://cr.openjdk.java.net/~kbarrett/8246032/open.05/

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-07-06 Thread Kim Barrett
I just noticed that doc/building.{md,html} describes minimum toolchain versions, so also needs to be updated. Here’s the update, matching what’s now in the JEP: full: https://cr.openjdk.java.net/~kbarrett/8246032/open.05/ incr: https://cr.openjdk.java.net/~kbarrett/8246032/open.05.inc/ I also

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-24 Thread Kim Barrett
> On Jun 24, 2020, at 7:01 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-18 08:34, Kim Barrett wrote: >>> On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: >>> On Jun 14, 2020, at 12:45 AM, Philip Race wrote: Kim, Until it says in "the JDK" and not "in

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-24 Thread Magnus Ihse Bursie
On 2020-06-18 08:34, Kim Barrett wrote: On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: On Jun 14, 2020, at 12:45 AM, Philip Race wrote: Kim, Until it says in "the JDK" and not "in HotSpot" you have not addressed my main point. Please rename the JEP. After some off-list discussions I

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-18 Thread Kim Barrett
> On Jun 15, 2020, at 7:41 AM, Kim Barrett wrote: > >> On Jun 14, 2020, at 12:45 AM, Philip Race wrote: >> >> Kim, >> >> >> Until it says in "the JDK" and not "in HotSpot" you have not addressed my >> main point. >> Please rename the JEP. After some off-list discussions I have a better

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-15 Thread Kim Barrett
> On Jun 14, 2020, at 12:45 AM, Philip Race wrote: > > Kim, > > > Until it says in "the JDK" and not "in HotSpot" you have not addressed my > main point. > Please rename the JEP. I think this JEP is primarily about updating the HotSpot-specific subset of C++ and usage guidance to include

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-13 Thread Philip Race
Kim, Until it says in "the JDK" and not "in HotSpot" you have not addressed my main point. Please rename the JEP. -phil. On 6/13/20, 8:48 PM, Kim Barrett wrote: On Jun 10, 2020, at 2:26 AM, Kim Barrett wrote: On Jun 8, 2020, at 4:07 PM, Philip Race wrote: BTW the JEP

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-13 Thread Kim Barrett
> On Jun 10, 2020, at 2:26 AM, Kim Barrett wrote: > >> On Jun 8, 2020, at 4:07 PM, Philip Race wrote: > >> BTW the JEP (https://bugs.openjdk.java.net/browse/JDK-8208089) still says >>> For Solaris: Add the -std=c++14 compiler option. . >> >> So I am sure there is still some room to update

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-10 Thread Kim Barrett
> On Jun 8, 2020, at 4:07 PM, Philip Race wrote: > > Hi Kim, > > Can we amend the JEP itself to be not solely about hotspot. > Since it affects other areas I think that > 1) They may need to be compiled with C++14 enabled whether they use new > features or not > 2) They may want - or need - to

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-08 Thread Philip Race
Hi Kim, Can we amend the JEP itself to be not solely about hotspot. Since it affects other areas I think that 1) They may need to be compiled with C++14 enabled whether they use new features or not 2) They may want - or need - to adopt C++11 or C++14 features too. You already know that soon

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-08 Thread Hendrik Schreiber
Jim, if there isn’t a dedicated bug report for this (meaning: lack of optimization for macOS), please do create one so that it at least is documented somewhere. Thank you, -hendrik > On Jun 5, 2020, at 13:59, Jim Laskey wrote: > > I know there was a discussion about this elsewhere but I

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-08 Thread Jim Laskey
Hendrik, Yes, I will file one once I have some data. The benefits are not clear cut and I should annotate the request with validity. :-) Cheers, -- Jim > On Jun 6, 2020, at 11:13 AM, Hendrik Schreiber wrote: > > Jim, > > if there isn’t a dedicated bug report for this (meaning: lack of

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-06 Thread James Laskey
I fully understand. I’ll set up a separate bug. Cheers, — Jim  > On Jun 5, 2020, at 8:57 PM, Magnus Ihse Bursie > wrote: > > On 2020-06-05 13:59, Jim Laskey wrote: >> I know there was a discussion about this elsewhere but I would like to take >> the opportunity to correct this now >>

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Kim Barrett
> On Jun 5, 2020, at 7:57 PM, Magnus Ihse Bursie > wrote: > > On 2020-06-05 09:52, Kim Barrett wrote: >> [Changes are only to the build system, but since the changes have jdk-wide >> effect I’ve cc’d what I think are the relevant dev lists.] >> >> This change is part of JEP 347; the intent is

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Kim Barrett
> On Jun 5, 2020, at 7:57 PM, Magnus Ihse Bursie > wrote: > > On 2020-06-05 13:59, Jim Laskey wrote: >> I know there was a discussion about this elsewhere but I would like to take >> the opportunity to correct this now >> >> make//autoconf/flags-cflags.m4:241 >> >> […] >> MacOSX has been

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Magnus Ihse Bursie
On 2020-06-05 09:52, Kim Barrett wrote: [Changes are only to the build system, but since the changes have jdk-wide effect I’ve cc’d what I think are the relevant dev lists.] This change is part of JEP 347; the intent is to target JDK 16. Please review this change to the building of C++ code in

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Magnus Ihse Bursie
On 2020-06-05 13:59, Jim Laskey wrote: I know there was a discussion about this elsewhere but I would like to take the opportunity to correct this now make//autoconf/flags-cflags.m4:241 elif test "x$TOOLCHAIN_TYPE" = xclang; then if test "x$OPENJDK_TARGET_OS" = xmacosx; then #

Re: RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Jim Laskey
I know there was a discussion about this elsewhere but I would like to take the opportunity to correct this now make//autoconf/flags-cflags.m4:241 elif test "x$TOOLCHAIN_TYPE" = xclang; then if test "x$OPENJDK_TARGET_OS" = xmacosx; then # On MacOSX we optimize for size, something

RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

2020-06-05 Thread Kim Barrett
[Changes are only to the build system, but since the changes have jdk-wide effect I’ve cc’d what I think are the relevant dev lists.] This change is part of JEP 347; the intent is to target JDK 16. Please review this change to the building of C++ code in the JDK to enable the use of C++14